- Several tests that are flakey on windows fail the run even if they are marked as expected to be flakey. This is because they fail frequently enough that even a retry won't help
- Skip several tests on Windows that will occasionally hang rather than failing or exiting. This is causing the entire test suite to hang
Oh, haha, that explains why it made no difference. Should we remove the expectedFlakey decorators entirely, so that they don't confuse anyone else (and replace them with a comment) or is there a plan to make them work again in the future?
I'm not sure. lit has a concept of a flakey test, and it would be nice to hook this up to that. However, that is going to be tricky as long as we have this disconnect between what lit considers a "test" and what our decorators do (see the "run each test separately" discussion).
The decorators also still serve a purpose when you run the test suite via dotest directly (our existing bots still do that, as the lit method does not cover all use cases). However, those bots may be turned down soon too, so I'm not sure how much we should optimize for that.