This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Armv8.2-A FP16 vector intrinsics tests
ClosedPublic

Authored by SjoerdMeijer on Aug 1 2018, 6:57 AM.

Details

Summary

Clang support for the Armv8.2-A FP16 vector intrinsic was committed in
rC328277, but this was never followed up, i.e. the LLVM part is missing.

I've raised PR38404, and this is the first step to address this. I.e.,
this adds tests for the Armv8.2-A FP16 vector intrinsic, and thus shows
which intrinsics already work, and which need further work.

Diff Detail

Repository
rL LLVM

Event Timeline

SjoerdMeijer created this revision.Aug 1 2018, 6:57 AM
olista01 accepted this revision.Aug 1 2018, 7:08 AM

LGTM with one nit.

test/CodeGen/ARM/armv8.2a-fp16-vector-intrinsics.ll
1 ↗(On Diff #158533)

There's only one check-prefix here, so you can just leave it at the default (CHECK).

This revision is now accepted and ready to land.Aug 1 2018, 7:08 AM
SjoerdMeijer added inline comments.Aug 1 2018, 7:13 AM
test/CodeGen/ARM/armv8.2a-fp16-vector-intrinsics.ll
1 ↗(On Diff #158533)

Thanks! I will address this before committing.

This revision was automatically updated to reflect the committed changes.