This is an archive of the discontinued LLVM Phabricator instance.

[UnJ] Add debug messages at to why loops are not unrolled. NFC
ClosedPublic

Authored by dmgreen on Jul 31 2018, 7:07 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

dmgreen created this revision.Jul 31 2018, 7:07 AM
Meinersbur accepted this revision.Jul 31 2018, 9:49 AM

LGTM.

lib/Transforms/Utils/LoopUnrollAndJam.cpp
757–758 ↗(On Diff #158232)

Could we name this in respect to what it returns? E.g. HasConsistentIterationCounts?

This revision is now accepted and ready to land.Jul 31 2018, 9:49 AM
xbolva00 added inline comments.
lib/Transforms/Utils/LoopUnrollAndJam.cpp
780 ↗(On Diff #158232)

may throw

Thanks

lib/Transforms/Utils/LoopUnrollAndJam.cpp
757–758 ↗(On Diff #158232)

There's another patch (D50063) which renames this again and pulls it out into a separate function. I'll rename it there.

780 ↗(On Diff #158232)

Will do

This revision was automatically updated to reflect the committed changes.