This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Fix new task creation
ClosedPublic

Authored by gtbercea on Jul 30 2018, 12:21 PM.

Reviewers

Commits

Summary

When OMPT is not supported the __kmp_omp_task() function is passed the parameters in the wrong order. This is a fix related to patch D47709.

gtbercea edited the summary of this revision. (Show Details)

I think this got messed up in D47709 (I marked the corresponding change inline). Can you update the summary on commit?

This revision is now accepted and ready to land.Jul 30 2018, 12:40 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

openmp/

trunk/

runtime/

src/

2 lines

	Show First 20 Lines • Show All 4,009 Lines • ▼ Show 20 Lines
	#if OMPT_SUPPORT			#if OMPT_SUPPORT
	p->codeptr_ra = codeptr_ra;			p->codeptr_ra = codeptr_ra;
	#endif			#endif

	#if OMPT_SUPPORT			#if OMPT_SUPPORT
	// schedule new task with correct return address for OMPT events			// schedule new task with correct return address for OMPT events
	__kmp_omp_taskloop_task(NULL, gtid, new_task, codeptr_ra);			__kmp_omp_taskloop_task(NULL, gtid, new_task, codeptr_ra);
	#else			#else
	__kmp_omp_task(NULL, gtid, new_task); // schedule new task			__kmp_omp_task(gtid, new_task, true); // schedule new task
	#endif			#endif

	// execute the 1st half of current subrange			// execute the 1st half of current subrange
	if (n_tsk0 > num_t_min)			if (n_tsk0 > num_t_min)
	__kmp_taskloop_recur(loc, gtid, task, lb, ub, st, ub_glob, n_tsk0, gr_size0,			__kmp_taskloop_recur(loc, gtid, task, lb, ub, st, ub_glob, n_tsk0, gr_size0,
	ext0, tc0, num_t_min,			ext0, tc0, num_t_min,
	#if OMPT_SUPPORT			#if OMPT_SUPPORT
	codeptr_ra,			codeptr_ra,
	▲ Show 20 Lines • Show All 181 Lines • Show Last 20 Lines