This is an archive of the discontinued LLVM Phabricator instance.

Differential D49997

[libcxx] Fix _LIBCPP_NO_EXCEPTIONS redefined warning
ClosedPublic

Authored by jasonl220 on Jul 30 2018, 11:37 AM.

Details

Reviewers
mclow.lists
EricWF
Summary

Fix GCC 7.2.0 redefinition warning when LIBCXX_ENABLE_EXCEPTIONS cmake option is not set.

llvm/projects/libcxx/include/__config:514:0: warning: "_LIBCPP_NO_EXCEPTIONS" redefined
#define _LIBCPP_NO_EXCEPTIONS

<command-line>:0:0: note: this is the location of the previous definition

This warning fires every time __config is included, 33 in total.

Diff Detail

Event Timeline

jasonl220 created this revision.Jul 30 2018, 11:37 AM
Herald added a reviewer: EricWF. · View Herald TranscriptJul 30 2018, 11:37 AM
Herald added subscribers: cfe-commits, ldionne. · View Herald Transcript
mclow.lists accepted this revision.Jul 31 2018, 7:03 PM

I'm fine with this; it matches the pattern used on line #354 of this file. (which is in the 'clang' block).

We don't do anything like this for the IBM or MS compilers - yet.

This revision is now accepted and ready to land.Jul 31 2018, 7:03 PM
jasonl220 added a comment.Aug 1 2018, 4:39 AM

Can you commit this for me, I don't have access. Thanks

ldionne closed this revision.EditedAug 1 2018, 6:13 AM

Committed as r338531.

Revision Contents

PathSize
2 lines

Diff 157891

__config

Show First 20 Lines • Show All 504 Lines • ▼ Show 20 Lines
#define _LIBCPP_IS_LITERAL(T) __is_literal_type(T) #define _LIBCPP_IS_LITERAL(T) __is_literal_type(T)
#define _LIBCPP_HAS_IS_FINAL #define _LIBCPP_HAS_IS_FINAL
#endif #endif
#if defined(__GNUC__) && _GNUC_VER >= 403 #if defined(__GNUC__) && _GNUC_VER >= 403
#define _LIBCPP_HAS_IS_BASE_OF #define _LIBCPP_HAS_IS_BASE_OF
#endif #endif
#if !__EXCEPTIONS #if !__EXCEPTIONS && !defined(_LIBCPP_NO_EXCEPTIONS)
#define _LIBCPP_NO_EXCEPTIONS #define _LIBCPP_NO_EXCEPTIONS
#endif #endif
// constexpr was added to GCC in 4.6. // constexpr was added to GCC in 4.6.
#if _GNUC_VER < 406 #if _GNUC_VER < 406
# define _LIBCPP_HAS_NO_CONSTEXPR # define _LIBCPP_HAS_NO_CONSTEXPR
// Can only use constexpr in c++11 mode. // Can only use constexpr in c++11 mode.
#elif !defined(__GXX_EXPERIMENTAL_CXX0X__) && __cplusplus < 201103L #elif !defined(__GXX_EXPERIMENTAL_CXX0X__) && __cplusplus < 201103L
▲ Show 20 Lines • Show All 831 Lines • Show Last 20 Lines