This is an archive of the discontinued LLVM Phabricator instance.

[ThinLTO] Handle optional args in assembly format for ConstVCalls
ClosedPublic

Authored by tejohnson on Jul 28 2018, 8:30 AM.

Details

Summary

The AsmWriter was only writing the Args for a ConstVCall if it was
non-empty, however, the LLParser was always expecting it. To aid
in making it optional, surround the ConstVCall VFuncId and Args in
parentheses when writing, then make the Args optional when reading.

Diff Detail

Event Timeline

tejohnson created this revision.Jul 28 2018, 8:30 AM
pcc accepted this revision.Aug 13 2018, 3:51 PM

LGTM

This revision is now accepted and ready to land.Aug 13 2018, 3:51 PM
This revision was automatically updated to reflect the committed changes.