This is an archive of the discontinued LLVM Phabricator instance.

Differential D49939

[ASAN] Use the correct shadow offset for ASAN on FreeBSD/mips64.
ClosedPublic

Authored by bsdjhb on Jul 27 2018, 2:53 PM.

Details

Reviewers
atanasyan
sdardis
Commits
rGc5d7e040522d: [ASAN] Use the correct shadow offset for ASAN on FreeBSD/mips64.
rL338650: [ASAN] Use the correct shadow offset for ASAN on FreeBSD/mips64.

Diff Detail

Event Timeline

bsdjhb created this revision.Jul 27 2018, 2:53 PM
Herald added subscribers: arichardson, emaste. · View Herald TranscriptJul 27 2018, 2:53 PM
bsdjhb mentioned this in D49942: [ASAN] Port asan to FreeBSD/mips64..Jul 27 2018, 3:08 PM
atanasyan accepted this revision.Jul 29 2018, 1:48 AM

LGTM

This revision is now accepted and ready to land.Jul 29 2018, 1:48 AM
Closed by commit rL338650: [ASAN] Use the correct shadow offset for ASAN on FreeBSD/mips64. (authored by jhb). · Explain WhyAug 1 2018, 3:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Transforms/
Instrumentation/
2 lines
test/
Instrumentation/
AddressSanitizer/
12 lines

Diff 157774

lib/Transforms/Instrumentation/AddressSanitizer.cpp

Show First 20 Lines • Show All 532 Lines • ▼ Show 20 Lines if (LongSize == 32) {
// Fuchsia is always PIE, which means that the beginning of the address // Fuchsia is always PIE, which means that the beginning of the address
// space is always available. // space is always available.
if (IsFuchsia) if (IsFuchsia)
Mapping.Offset = 0; Mapping.Offset = 0;
else if (IsPPC64) else if (IsPPC64)
Mapping.Offset = kPPC64_ShadowOffset64; Mapping.Offset = kPPC64_ShadowOffset64;
else if (IsSystemZ) else if (IsSystemZ)
Mapping.Offset = kSystemZ_ShadowOffset64; Mapping.Offset = kSystemZ_ShadowOffset64;
else if (IsFreeBSD) else if (IsFreeBSD && !IsMIPS64)
Mapping.Offset = kFreeBSD_ShadowOffset64; Mapping.Offset = kFreeBSD_ShadowOffset64;
else if (IsNetBSD) else if (IsNetBSD)
Mapping.Offset = kNetBSD_ShadowOffset64; Mapping.Offset = kNetBSD_ShadowOffset64;
else if (IsPS4CPU) else if (IsPS4CPU)
Mapping.Offset = kPS4CPU_ShadowOffset64; Mapping.Offset = kPS4CPU_ShadowOffset64;
else if (IsLinux && IsX86_64) { else if (IsLinux && IsX86_64) {
if (IsKasan) if (IsKasan)
Mapping.Offset = kLinuxKasan_ShadowOffset64; Mapping.Offset = kLinuxKasan_ShadowOffset64;
▲ Show 20 Lines • Show All 2,674 Lines • Show Last 20 Lines

test/Instrumentation/AddressSanitizer/freebsd.ll

; RUN: opt < %s -asan -asan-module -S \ ; RUN: opt < %s -asan -asan-module -S \
; RUN: -mtriple=i386-unknown-freebsd \ ; RUN: -mtriple=i386-unknown-freebsd \
; RUN: -data-layout="e-m:e-p:32:32-f64:32:64-f80:32-n8:16:32-S128" | \ ; RUN: -data-layout="e-m:e-p:32:32-f64:32:64-f80:32-n8:16:32-S128" | \
; RUN: FileCheck --check-prefix=CHECK-32 %s ; RUN: FileCheck --check-prefix=CHECK-32 %s
; RUN: opt < %s -asan -asan-module -S \ ; RUN: opt < %s -asan -asan-module -S \
; RUN: -mtriple=x86_64-unknown-freebsd \ ; RUN: -mtriple=x86_64-unknown-freebsd \
; RUN: -data-layout="e-m:e-i64:64-f80:128-n8:16:32:64-S128" | \ ; RUN: -data-layout="e-m:e-i64:64-f80:128-n8:16:32:64-S128" | \
; RUN: FileCheck --check-prefix=CHECK-64 %s ; RUN: FileCheck --check-prefix=CHECK-64 %s
; RUN: opt < %s -asan -asan-module -S \
; RUN: -mtriple=mips64-unknown-freebsd \
; RUN: -data-layout="E-m:e-i64:64-n32:64-S128" | \
; RUN: FileCheck --check-prefix=CHECK-MIPS64 %s
define i32 @read_4_bytes(i32* %a) sanitize_address { define i32 @read_4_bytes(i32* %a) sanitize_address {
entry: entry:
%tmp1 = load i32, i32* %a, align 4 %tmp1 = load i32, i32* %a, align 4
ret i32 %tmp1 ret i32 %tmp1
} }
; CHECK-32: @read_4_bytes ; CHECK-32: @read_4_bytes
; CHECK-32-NOT: ret ; CHECK-32-NOT: ret
; Check for ASAN's Offset for 32-bit (2^30 or 0x40000000) ; Check for ASAN's Offset for 32-bit (2^30 or 0x40000000)
; CHECK-32: lshr {{.*}} 3 ; CHECK-32: lshr {{.*}} 3
; CHECK-32-NEXT: {{1073741824}} ; CHECK-32-NEXT: {{1073741824}}
; CHECK-32: ret ; CHECK-32: ret
; CHECK-64: @read_4_bytes ; CHECK-64: @read_4_bytes
; CHECK-64-NOT: ret ; CHECK-64-NOT: ret
; Check for ASAN's Offset for 64-bit (2^46 or 0x400000000000) ; Check for ASAN's Offset for 64-bit (2^46 or 0x400000000000)
; CHECK-64: lshr {{.*}} 3 ; CHECK-64: lshr {{.*}} 3
; CHECK-64-NEXT: {{70368744177664}} ; CHECK-64-NEXT: {{70368744177664}}
; CHECK-64: ret ; CHECK-64: ret
; CHECK-MIPS64: @read_4_bytes
; CHECK-MIPS64-NOT: ret
; Check for ASAN's Offset for 64-bit (2^37 or 0x2000000000)
; CHECK-MIPS64: lshr {{.*}} 3
; CHECK-MIPS64-NEXT: {{137438953472}}
; CHECK-MIPS64: ret