D49916.
ClosedPublic
Actions

Authored by calixte on Jul 27 2018, 7:25 AM.

Details

Reviewers

marco-c
davidxl

Commits

rG8f7aab5c61c6: [profile] Fix the tests for patch in https://reviews.llvm.org/D49916.
rCRT342718: [profile] Fix the tests for patch in https://reviews.llvm.org/D49916.
rL342718: [profile] Fix the tests for patch in https://reviews.llvm.org/D49916.

Summary

The goal of D49916 is to remove some hit counters from lines like '}'.
So as a consequence, the tests must be fixed.
FYI, after holidays, I'll add more tests.

Diff Detail

Repository: rL LLVM

Event Timeline

calixte created this revision.Jul 27 2018, 7:25 AM

Herald added subscribers: Restricted Project, llvm-commits, delcypher. · View Herald TranscriptJul 27 2018, 7:25 AM

Harbormaster completed remote builds in B20787: Diff 157687.Jul 27 2018, 7:26 AM

calixte edited the summary of this revision. (Show Details)Jul 27 2018, 7:26 AM

marco-c added inline comments.Sep 20 2018, 2:40 AM

test/profile/Inputs/instrprof-dlopen-func.c.gcov
6 ↗	(On Diff #157687)	Shouldn't this be 1?

calixte added inline comments.Sep 21 2018, 1:58 AM

test/profile/Inputs/instrprof-dlopen-func.c.gcov
6 ↗	(On Diff #157687)	With the patch to attach function line def to first block, we'll have 1. But here we've 0 since "ret void" isn't instrumented.

Fix the tests.

Harbormaster completed remote builds in B22911: Diff 166413.Sep 21 2018, 1:58 AM

marco-c accepted this revision.Sep 21 2018, 2:11 AM

This revision is now accepted and ready to land.Sep 21 2018, 2:11 AM

Closed by commit rL342718: [profile] Fix the tests for patch in https://reviews.llvm.org/D49916. (authored by calixte). · Explain WhySep 21 2018, 2:18 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

compiler-rt/

trunk/

test/

profile/

Inputs/

instrprof-dlopen-dlclose-main.c.gcov

2 lines

instrprof-dlopen-dlclose-main_three-libs.c.gcov

2 lines

instrprof-dlopen-func.c.gcov

2 lines

instrprof-dlopen-func2.c.gcov

2 lines

instrprof-dlopen-func3.c.gcov

2 lines

instrprof-gcov-exceptions.cpp.gcov

2 lines

instrprof-gcov-multiple-bbs-single-line.c.gcov

4 lines

instrprof-shared-lib.c.gcov

2 lines

instrprof-shared-lib_called-twice.c.gcov

2 lines

instrprof-shared-lib_in-loop.c.gcov

2 lines

instrprof-shared-main-gcov-flush_no-writeout.c.gcov

4 lines

instrprof-shared-main-gcov-flush_shared-call-after.c.gcov

2 lines

instrprof-shared-main-gcov-flush_shared-call-before-after.c.gcov

2 lines

instrprof-shared-main-gcov-flush_shared-call-before.c.gcov

2 lines

instrprof-shared-main.c.gcov

4 lines

instrprof-gcov-exceptions.test

3 lines

Diff 166417

View Options

compiler-rt/trunk/test/profile/Inputs/instrprof-dlopen-dlclose-main.c.gcov

View Options

compiler-rt/trunk/test/profile/Inputs/instrprof-dlopen-dlclose-main_three-libs.c.gcov

View Options

compiler-rt/trunk/test/profile/Inputs/instrprof-dlopen-func.c.gcov

View Options

compiler-rt/trunk/test/profile/Inputs/instrprof-dlopen-func2.c.gcov

View Options

compiler-rt/trunk/test/profile/Inputs/instrprof-dlopen-func3.c.gcov

View Options

compiler-rt/trunk/test/profile/Inputs/instrprof-gcov-exceptions.cpp.gcov

View Options

compiler-rt/trunk/test/profile/Inputs/instrprof-gcov-multiple-bbs-single-line.c.gcov

View Options

compiler-rt/trunk/test/profile/Inputs/instrprof-shared-lib.c.gcov

View Options

compiler-rt/trunk/test/profile/Inputs/instrprof-shared-lib_called-twice.c.gcov

View Options

compiler-rt/trunk/test/profile/Inputs/instrprof-shared-lib_in-loop.c.gcov

View Options

compiler-rt/trunk/test/profile/Inputs/instrprof-shared-main-gcov-flush_no-writeout.c.gcov

View Options

compiler-rt/trunk/test/profile/Inputs/instrprof-shared-main-gcov-flush_shared-call-after.c.gcov

View Options

compiler-rt/trunk/test/profile/Inputs/instrprof-shared-main-gcov-flush_shared-call-before-after.c.gcov

View Options

compiler-rt/trunk/test/profile/Inputs/instrprof-shared-main-gcov-flush_shared-call-before.c.gcov

View Options

compiler-rt/trunk/test/profile/Inputs/instrprof-shared-main.c.gcov

View Options

compiler-rt/trunk/test/profile/instrprof-gcov-exceptions.test

[profile] Fix the tests for patch in https://reviews.llvm.org/D49916.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 166417

compiler-rt/trunk/test/profile/Inputs/instrprof-dlopen-dlclose-main.c.gcov

compiler-rt/trunk/test/profile/Inputs/instrprof-dlopen-dlclose-main_three-libs.c.gcov

compiler-rt/trunk/test/profile/Inputs/instrprof-dlopen-func.c.gcov

compiler-rt/trunk/test/profile/Inputs/instrprof-dlopen-func2.c.gcov

compiler-rt/trunk/test/profile/Inputs/instrprof-dlopen-func3.c.gcov

compiler-rt/trunk/test/profile/Inputs/instrprof-gcov-exceptions.cpp.gcov

compiler-rt/trunk/test/profile/Inputs/instrprof-gcov-multiple-bbs-single-line.c.gcov

compiler-rt/trunk/test/profile/Inputs/instrprof-shared-lib.c.gcov

compiler-rt/trunk/test/profile/Inputs/instrprof-shared-lib_called-twice.c.gcov

compiler-rt/trunk/test/profile/Inputs/instrprof-shared-lib_in-loop.c.gcov

compiler-rt/trunk/test/profile/Inputs/instrprof-shared-main-gcov-flush_no-writeout.c.gcov

compiler-rt/trunk/test/profile/Inputs/instrprof-shared-main-gcov-flush_shared-call-after.c.gcov

compiler-rt/trunk/test/profile/Inputs/instrprof-shared-main-gcov-flush_shared-call-before-after.c.gcov

compiler-rt/trunk/test/profile/Inputs/instrprof-shared-main-gcov-flush_shared-call-before.c.gcov

compiler-rt/trunk/test/profile/Inputs/instrprof-shared-main.c.gcov

compiler-rt/trunk/test/profile/instrprof-gcov-exceptions.test

[profile] Fix the tests for patch in https://reviews.llvm.org/D49916.
ClosedPublic
Actions

Revision Contents
Changeset List