This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Stop trying to exend arguments for clover
ClosedPublic

Authored by arsenm on Jul 27 2018, 1:38 AM.

Details

Reviewers
jvesely
Summary

This was trying to replace i8/i16 arguments with i32, which
was broken and no longer necessary.

Diff Detail

Event Timeline

arsenm created this revision.Jul 27 2018, 1:38 AM
jvesely accepted this revision.Jul 27 2018, 12:14 PM

I've been using a version of this locally and it fixes most, but not all tests with char/uchar/short/ushort kernel arguments.
I thought that fixing the hardcoded alignemnt=4 would help, but it's not enough.
It'll need to be handled separately.

LGTM

This revision is now accepted and ready to land.Jul 27 2018, 12:14 PM
arsenm closed this revision.Jul 28 2018, 5:34 AM