This is an archive of the discontinued LLVM Phabricator instance.

Differential D49835

CMake: Remove LLVM_DYLIB_SYMBOL_VERSIONING
ClosedPublic

Authored by tstellar on Jul 25 2018, 9:44 PM.

Details

Reviewers
sylvestre.ledru
beanz
mgorny
Commits
rGceaf95f93d63: Merging r338751: --------------------------------------------------------------…
rG910f70238ca3: CMake: Remove LLVM_DYLIB_SYMBOL_VERSIONING
rL338842: Merging r338751:
rL338751: CMake: Remove LLVM_DYLIB_SYMBOL_VERSIONING
Summary

This option is no longer needed since r300496 added symbol
versioning by default

Diff Detail

Event Timeline

tstellar created this revision.Jul 25 2018, 9:44 PM
mgorny accepted this revision.Jul 25 2018, 11:32 PM

Makes sense. Thanks!

This revision is now accepted and ready to land.Jul 25 2018, 11:32 PM
Closed by commit rL338751: CMake: Remove LLVM_DYLIB_SYMBOL_VERSIONING (authored by tstellar). · Explain WhyAug 2 2018, 11:16 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
2 lines
tools/
llvm-shlib/
4 lines

Diff 157424

CMakeLists.txt

Show First 20 Lines • Show All 551 Lines • ▼ Show 20 Lines
option(LLVM_LINK_LLVM_DYLIB "Link tools against the libllvm dynamic library" OFF) option(LLVM_LINK_LLVM_DYLIB "Link tools against the libllvm dynamic library" OFF)
option(LLVM_BUILD_LLVM_C_DYLIB "Build libllvm-c re-export library (Darwin Only)" OFF) option(LLVM_BUILD_LLVM_C_DYLIB "Build libllvm-c re-export library (Darwin Only)" OFF)
set(LLVM_BUILD_LLVM_DYLIB_default OFF) set(LLVM_BUILD_LLVM_DYLIB_default OFF)
if(LLVM_LINK_LLVM_DYLIB OR LLVM_BUILD_LLVM_C_DYLIB) if(LLVM_LINK_LLVM_DYLIB OR LLVM_BUILD_LLVM_C_DYLIB)
set(LLVM_BUILD_LLVM_DYLIB_default ON) set(LLVM_BUILD_LLVM_DYLIB_default ON)
endif() endif()
option(LLVM_BUILD_LLVM_DYLIB "Build libllvm dynamic library" ${LLVM_BUILD_LLVM_DYLIB_default}) option(LLVM_BUILD_LLVM_DYLIB "Build libllvm dynamic library" ${LLVM_BUILD_LLVM_DYLIB_default})
option(LLVM_DYLIB_SYMBOL_VERSIONING OFF)
option(LLVM_OPTIMIZED_TABLEGEN "Force TableGen to be built with optimization" OFF) option(LLVM_OPTIMIZED_TABLEGEN "Force TableGen to be built with optimization" OFF)
if(CMAKE_CROSSCOMPILING OR (LLVM_OPTIMIZED_TABLEGEN AND (LLVM_ENABLE_ASSERTIONS OR CMAKE_CONFIGURATION_TYPES))) if(CMAKE_CROSSCOMPILING OR (LLVM_OPTIMIZED_TABLEGEN AND (LLVM_ENABLE_ASSERTIONS OR CMAKE_CONFIGURATION_TYPES)))
set(LLVM_USE_HOST_TOOLS ON) set(LLVM_USE_HOST_TOOLS ON)
endif() endif()
if (MSVC_IDE AND NOT (MSVC_VERSION LESS 1900)) if (MSVC_IDE AND NOT (MSVC_VERSION LESS 1900))
option(LLVM_ADD_NATIVE_VISUALIZERS_TO_SOLUTION "Configure project to use Visual Studio native visualizers" TRUE) option(LLVM_ADD_NATIVE_VISUALIZERS_TO_SOLUTION "Configure project to use Visual Studio native visualizers" TRUE)
else() else()
▲ Show 20 Lines • Show All 475 Lines • Show Last 20 Lines

tools/llvm-shlib/CMakeLists.txt

Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Lines if (NOT LLVM_LINKER_IS_SOLARISLD)
set(LIB_NAMES -Wl,--version-script,${LLVM_LIBRARY_DIR}/tools/llvm-shlib/simple_version_script.map ${LIB_NAMES}) set(LIB_NAMES -Wl,--version-script,${LLVM_LIBRARY_DIR}/tools/llvm-shlib/simple_version_script.map ${LIB_NAMES})
endif() endif()
elseif("${CMAKE_SYSTEM_NAME}" STREQUAL "Darwin") elseif("${CMAKE_SYSTEM_NAME}" STREQUAL "Darwin")
set(LIB_NAMES -Wl,-all_load ${LIB_NAMES}) set(LIB_NAMES -Wl,-all_load ${LIB_NAMES})
endif() endif()
target_link_libraries(LLVM PRIVATE ${LIB_NAMES}) target_link_libraries(LLVM PRIVATE ${LIB_NAMES})
if (LLVM_DYLIB_SYMBOL_VERSIONING)
set_property(TARGET LLVM APPEND_STRING PROPERTY LINK_FLAGS " -Wl,--default-symver")
endif()
if (APPLE) if (APPLE)
set_property(TARGET LLVM APPEND_STRING PROPERTY set_property(TARGET LLVM APPEND_STRING PROPERTY
LINK_FLAGS LINK_FLAGS
" -compatibility_version 1 -current_version ${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}") " -compatibility_version 1 -current_version ${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}")
endif() endif()
if(TARGET libLLVMExports) if(TARGET libLLVMExports)
add_dependencies(LLVM libLLVMExports) add_dependencies(LLVM libLLVMExports)
Show All 37 Lines