This is an archive of the discontinued LLVM Phabricator instance.

Handle the lack of a symbol table correctly.
ClosedPublic

Authored by srhines on Jul 19 2018, 1:51 AM.

Details

Summary

These two cases will trigger a dereference on a nullptr, since the
SymbolTable can be nonexistent for a given library, in addition to just
being empty.

Diff Detail

Event Timeline

srhines created this revision.Jul 19 2018, 1:51 AM
srhines updated this revision to Diff 156220.Jul 19 2018, 1:55 AM

Ran git-clang-format and added rationale to the test.

srhines updated this revision to Diff 156230.Jul 19 2018, 4:05 AM
  • Fix positional output argument for llvm-strip.
tools/llvm-objcopy/llvm-objcopy.cpp
653

if i understand correctly, this line should be reverted back as discussed on the other diff + remove the lines 45-49 in the test.

the other change (line 418 + tests) looks fine to me

srhines updated this revision to Diff 156625.Jul 20 2018, 3:48 PM

Revert back to not layering the positional argument change.

srhines marked an inline comment as done.Jul 20 2018, 3:49 PM

I restored the original change, since I had confused things with arcanist before. PTAL

This revision is now accepted and ready to land.Jul 21 2018, 12:55 AM

@srhines - is there anything blocking this diff ?

In D49534#1177242, @alexshap wrote:

@srhines - is there anything blocking this diff ?

Nope, I just missed that it was approved (and promptly forgot about it since I was chasing other problems). I will go ahead and submit it. Thanks for the review.

This revision was automatically updated to reflect the committed changes.