This is an archive of the discontinued LLVM Phabricator instance.

[libFuzzer] Avoid STL in MSan test.
ClosedPublic

Authored by morehouse on Jul 16 2018, 3:43 PM.

Details

Summary

STL can cause MSan false positives if lib[std]c++ isn't instrumented with MSan

Event Timeline

morehouse created this revision.Jul 16 2018, 3:43 PM
kcc added a comment.Jul 16 2018, 3:52 PM

err... partially taking my word back.. I do want to keep this test to use STL.
Instead of this change, please create another test, e.g. SimpleTestStdio.cpp, that won't use STL, and use the new test in msan runs.

morehouse updated this revision to Diff 155778.Jul 16 2018, 4:02 PM
  • Revert "[libFuzzer] Avoid std::cout in SimpleTest."
  • Create SimpleTestStdio.cpp without STL.
morehouse retitled this revision from [libFuzzer] Avoid std::cout in SimpleTest. to [libFuzzer] Avoid STL in MSan test..Jul 16 2018, 4:02 PM
morehouse edited the summary of this revision. (Show Details)
kcc accepted this revision.Jul 16 2018, 4:05 PM

LGTM

This revision is now accepted and ready to land.Jul 16 2018, 4:05 PM
This revision was automatically updated to reflect the committed changes.