This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Pass CMAKE_INSTALL_DO_STRIP to external projects
ClosedPublic

Authored by phosek on Jul 13 2018, 8:13 PM.

Reviewers

smeenai
beanz

Commits

Summary

This is necessary to make install-<target>-stripped work for
external projects such as runtimes.

LGTM

This revision is now accepted and ready to land.Jul 13 2018, 10:47 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

trunk/

cmake/

modules/

2 lines

Show First 20 Lines • Show All 215 Lines • ▼ Show 20 Lines	function(llvm_ExternalProject_Add name source_dir)

if(ARG_USE_TOOLCHAIN)		if(ARG_USE_TOOLCHAIN)
add_dependencies(${name}-clean ${name}-clobber)		add_dependencies(${name}-clean ${name}-clobber)
set_target_properties(${name}-clean PROPERTIES		set_target_properties(${name}-clean PROPERTIES
SOURCES ${CMAKE_CURRENT_BINARY_DIR}/${name}-clobber-stamp)		SOURCES ${CMAKE_CURRENT_BINARY_DIR}/${name}-clobber-stamp)
endif()		endif()

if(NOT ARG_NO_INSTALL)		if(NOT ARG_NO_INSTALL)
install(CODE "execute_process$COMMAND \${CMAKE_COMMAND} -DCMAKE_INSTALL_PREFIX=\${CMAKE_INSTALL_PREFIX} -P ${BINARY_DIR}/cmake_install.cmake $"		install(CODE "execute_process$COMMAND \${CMAKE_COMMAND} -DCMAKE_INSTALL_PREFIX=\${CMAKE_INSTALL_PREFIX} -DCMAKE_INSTALL_DO_STRIP=\${CMAKE_INSTALL_DO_STRIP} -P ${BINARY_DIR}/cmake_install.cmake$"
COMPONENT ${name})		COMPONENT ${name})

add_llvm_install_targets(install-${name}		add_llvm_install_targets(install-${name}
DEPENDS ${name}		DEPENDS ${name}
COMPONENT ${name})		COMPONENT ${name})
endif()		endif()

# Add top-level targets		# Add top-level targets
Show All 15 Lines