This is an archive of the discontinued LLVM Phabricator instance.

Added Image Processing Kernels Using Benchmark Library
AbandonedPublic

Authored by proton on Jul 12 2018, 9:00 AM.

Details

Summary

I will be adding some more kernels to the same directory (ImageProcessing) using the benchmark library. which will Include
-> Other Dither Kernels
-> Dilate
-> Histogram

Since it will become too big to check if I add all of them together, I am adding some of them for now. Let me know if anyone has any suggestion on kernels that he/she would like to have in llvm-test-suite using benchmark library.

Diff Detail

Event Timeline

proton created this revision.Jul 12 2018, 9:00 AM

@proton Thank you for the new benchmarks!

IHMO we should have one review and commit per benchmark. This would make it easier to revert an individual benchmark when it fails.

MicroBenchmarks/ImageProcessing/Blur/main.cpp
130

[typo] We read _the_ entire

MicroBenchmarks/ImageProcessing/utils/ImageHelper.cpp
8

Other benchmarks use drand48(). Maybe we should use it as well.

MicroBenchmarks/ImageProcessing/utils/ImageHelper.h
5–10

These should go into the .cpp file.

proton abandoned this revision.Aug 6 2018, 6:15 AM

Adding each kernel in separate patches so that it will be easy to review and also we can revert only that kernel which causes problems (if any).