This is an archive of the discontinued LLVM Phabricator instance.

[MachineOutliner] Assert that Liveness tracking is accurate (NFC)
ClosedPublic

Authored by yroux on Jul 6 2018, 7:31 AM.

Details

Summary

The checking is done deeper inside MachineBasicBlock, but this will hopefully help to find issues when porting the machine outliner to a target where Liveness tracking is broken (like ARM) .

Diff Detail

Repository
rL LLVM

Event Timeline

yroux created this revision.Jul 6 2018, 7:31 AM
paquette added inline comments.Jul 6 2018, 8:53 AM
include/llvm/CodeGen/MachineOutliner.h
145

Can you add a message to the assert like "Candidate's MF must track liveness"? It's a bit nicer to have some context with asserts in my experience.

yroux added inline comments.Jul 6 2018, 12:05 PM
include/llvm/CodeGen/MachineOutliner.h
145

Yes I hesitated to add one, but you're right it'd be more helpfull

yroux updated this revision to Diff 154445.Jul 6 2018, 12:16 PM
paquette accepted this revision.Jul 6 2018, 1:23 PM

LGTM

This revision is now accepted and ready to land.Jul 6 2018, 1:23 PM
This revision was automatically updated to reflect the committed changes.