Page MenuHomePhabricator

[Polly][isl] Add neutrally-named accessors to isl list elements and sizes
ClosedPublic

Authored by philip.pfaffe on Jul 6 2018, 4:54 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

philip.pfaffe created this revision.Jul 6 2018, 4:54 AM
grosser accepted this revision.Jul 6 2018, 7:27 AM

LGTM

This revision is now accepted and ready to land.Jul 6 2018, 7:27 AM

Where's the code for the generator?

Where's the code for the generator?

I didn't add it to the generator. Do we actually ever generate the header?

Tobias does from time-to-time. Last time was r333688 on 2018-05-31.

Right. I am busy today, but can do a normal update thursday afternoon. I will then also push the current generator to github.

Is the generator in the repo?

I have a patched version of the generator (very hacky) on top of the isl bindings. Not sure if this (happens to) be the right one: https://github.com/tobig/isl/tree/polly-bindings-andrei

You can try, but otherwise, I will cross-check myself on thursday.

Should I commit this change, or wait until the generator is updated and recreate it using that?

You can commit this. It will just be covered in the next update.

This revision was automatically updated to reflect the committed changes.