Page MenuHomePhabricator

[clang-move] ClangMoveTests: Remove dots in output paths

Authored by simark on Jul 4 2018, 1:46 PM.



Following D48903 ([VirtualFileSystem] InMemoryFileSystem::status: Return
a Status with the requested name), the paths output by clang-move in the
FileToReplacements map may contain leading "./". For example, where we
would get "foo.h", we'll now get "./foo.h". This breaks the tests,
because we are doing exact string lookups in the FileToFileID and
Results maps (they contain "foo.h", but we search for "./foo.h").

To mitigate this, try to normalize a little bit the paths output by
clang-move to remove that leading "./".

This patch should be safe to merge before D48903, remove_dots will just
be a no-op.

Diff Detail


Event Timeline

simark created this revision.Jul 4 2018, 1:46 PM
hokein accepted this revision.Jul 5 2018, 7:45 AM

Looks good.

This revision is now accepted and ready to land.Jul 5 2018, 7:45 AM
This revision was automatically updated to reflect the committed changes.