This is an archive of the discontinued LLVM Phabricator instance.

[ASTMatchers] A matcher for Objective-C @autoreleasepool
ClosedPublic

Authored by george.karpenkov on Jul 3 2018, 6:32 PM.

Diff Detail

Event Timeline

This revision is now accepted and ready to land.Jul 4 2018, 7:12 AM
aaron.ballman requested changes to this revision.Jul 4 2018, 7:19 AM

This mostly looks good, but the name of the matcher is inconsistent.

include/clang/ASTMatchers/ASTMatchers.h
980 ↗(On Diff #154037)

This should be named autoreleasePoolStmt().

This revision now requires changes to proceed.Jul 4 2018, 7:19 AM
aaron.ballman accepted this revision.Jul 6 2018, 5:08 AM

LGTM, thank you!

This revision is now accepted and ready to land.Jul 6 2018, 5:08 AM
This revision was automatically updated to reflect the committed changes.