This is an archive of the discontinued LLVM Phabricator instance.

[ARM][NFC] Refactor sequential access for DSP
ClosedPublic

Authored by samparker on Jul 3 2018, 4:18 AM.

Details

Summary

With a view to support parallel operations that have their results stored to memory, refactor the consecutive access helper out so it could support stores instructions.

Diff Detail

Event Timeline

samparker created this revision.Jul 3 2018, 4:18 AM
SjoerdMeijer accepted this revision.Jul 3 2018, 4:59 AM

Looks OK to me.

lib/Target/ARM/ARMParallelDSP.cpp
61

Nit: does the comment now needs updating? I.e., that it can be any instruction touching memory?

This revision is now accepted and ready to land.Jul 3 2018, 4:59 AM
samparker added inline comments.Jul 3 2018, 5:36 AM
lib/Target/ARM/ARMParallelDSP.cpp
61

I don't think so. We're still expecting the ParallelMACs to operate directly on loaded data and that there aren't any stores in the chain. I will change and update this structure later - and I will try to remember to update the comments then!

This revision was automatically updated to reflect the committed changes.