This is an archive of the discontinued LLVM Phabricator instance.

[llvm-exegesis] Delegate the decision of cycle counter name to the target
ClosedPublic

Authored by john.brawn on Jun 29 2018, 10:45 AM.

Details

Summary

Currently the cycle counter is taken from the subtarget schedule model, which isn't any use if the subtarget doesn't have one. Delegate the decision to the target benchmark runner, as it may know better what to do in that case, with the default being the current behaviour.

Diff Detail

Repository
rL LLVM

Event Timeline

john.brawn created this revision.Jun 29 2018, 10:45 AM
courbet accepted this revision.Jun 30 2018, 2:58 AM

Just two minor comments.

tools/llvm-exegesis/lib/Latency.cpp
98

I think you can remove this fixme now.

117

You need to keep the test for nullity, just in case the implementation returns nullptr.

This revision is now accepted and ready to land.Jun 30 2018, 2:58 AM
This revision was automatically updated to reflect the committed changes.