Page MenuHomePhabricator

[polly-acc] change cl_get_* return types to 32/64bit
ClosedPublic

Authored by alaindenzler on Jun 29 2018, 8:33 AM.

Details

Summary

This patch changes the return types for ocl_get_* functions during SPIR code generation. Because these functions return size_t types, the return type needs to be changed to the actual size of size_t on the device.

Based on work by Michal Babej and Pekka Jääskeläinen

Diff Detail

Repository
rL LLVM

Event Timeline

alaindenzler created this revision.Jun 29 2018, 8:33 AM
philip.pfaffe accepted this revision.Jun 29 2018, 11:46 AM

LGTM, thanks!

This revision is now accepted and ready to land.Jun 29 2018, 11:46 AM
grosser accepted this revision.Jun 29 2018, 2:20 PM

Also looks good from me except the minor changes. Please update the patch if you agree.

Then Philip or me can commit it.

lib/CodeGen/PPCGCodeGeneration.cpp
582 ↗(On Diff #153499)

Can you document the new parameter.

test/GPGPU/spir-typesize.ll
91 ↗(On Diff #153499)

Maybe add a newline here.

Updated documentation and newline at the end of the test file.

This revision was automatically updated to reflect the committed changes.