This was introducing unnecessary padding after the explicit
arguments, depending on the alignment of the total struct type.
Also has the side effect of avoiding creating an extra GEP for
the offset from the base kernel argument to the explicit kernel
argument offset.
Details
Details
- Reviewers
rampitec
Diff Detail
Diff Detail
Event Timeline
test/CodeGen/AMDGPU/kernel-args.ll | ||
---|---|---|
672 ↗ | (On Diff #153460) | Ideally we want to have load_dwordx3 here. Do you mind to add checks for load instructions? |
test/CodeGen/AMDGPU/kernel-args.ll | ||
---|---|---|
672 ↗ | (On Diff #153460) | Actually, dwordx4 given the padding. |
test/CodeGen/AMDGPU/kernel-args.ll | ||
---|---|---|
672 ↗ | (On Diff #153460) | Actually these tests should be dropped from the patch. I added these for a later patch, and forgot to add the check lines since those belong later |