Page MenuHomePhabricator

[PCH+Modules] Load -fmodule-map-file content before including PCHs
ClosedPublic

Authored by bruno on Jun 27 2018, 4:45 PM.

Details

Summary

Consider:

  1. Generate PCH with -fmodules and -fmodule-map-file
  2. Use PCH with -fmodules and the same -fmodule-map-file

If we don't load -fmodule-map-file content before including PCHs, the modules that are dependencies in PCHs cannot get loaded, since there's no matching module map file when reading back the AST.

rdar://problem/40852867

Diff Detail

Repository
rL LLVM

Event Timeline

bruno created this revision.Jun 27 2018, 4:45 PM
This revision is now accepted and ready to land.Jul 9 2018, 11:52 AM
This revision was automatically updated to reflect the committed changes.