This is an archive of the discontinued LLVM Phabricator instance.

Differential D48622

[llvm-objdump] Add -x --all-headers options
ClosedPublic

Authored by MaskRay on Jun 26 2018, 11:58 PM.

Details

Reviewers
paulsemel
echristo
Commits
rG8513cd4c0e57: [llvm-objdump] Add -x --all-headers options
rL335785: [llvm-objdump] Add -x --all-headers options

Diff Detail

Event Timeline

MaskRay created this revision.Jun 26 2018, 11:58 PM
Herald added a subscriber: llvm-commits. · View Herald TranscriptJun 26 2018, 11:58 PM
paulsemel added a reviewer: echristo.Jun 27 2018, 2:04 AM
paulsemel accepted this revision.Jun 27 2018, 2:37 AM

It seems to be displaying the correct information.
I just noticed that we are not printing dynamic section in the -private-headers option, this might somehow be fixed.

LGTM, but please, wait for @echristo approval :)

This revision is now accepted and ready to land.Jun 27 2018, 2:37 AM
MaskRay added a comment.Jun 27 2018, 8:43 AM
In D48622#1144670, @paulsemel wrote:

It seems to be displaying the correct information.
I just noticed that we are not printing dynamic section in the -private-headers option, this might somehow be fixed.

LGTM, but please, wait for @echristo approval :)

We also lack -a (--archive-headers) and -f (--file-headers) :)

paulsemel added a comment.Jun 27 2018, 1:33 PM
In D48622#1145147, @MaskRay wrote:
In D48622#1144670, @paulsemel wrote:

It seems to be displaying the correct information.
I just noticed that we are not printing dynamic section in the -private-headers option, this might somehow be fixed.

LGTM, but please, wait for @echristo approval :)

We also lack -a (--archive-headers) and -f (--file-headers) :)

That's right, I will take a look at it when I have more time, thanks a lot ! :)

MaskRay added a comment.Jun 27 2018, 1:41 PM
In D48622#1145608, @paulsemel wrote:
In D48622#1145147, @MaskRay wrote:
In D48622#1144670, @paulsemel wrote:

It seems to be displaying the correct information.
I just noticed that we are not printing dynamic section in the -private-headers option, this might somehow be fixed.

LGTM, but please, wait for @echristo approval :)

We also lack -a (--archive-headers) and -f (--file-headers) :)

That's right, I will take a look at it when I have more time, thanks a lot ! :)

And FYI https://lists.freebsd.org/pipermail/freebsd-toolchain/2018-June/003809.html FreeBSD devs are moving away from GNU binutils and migrating to LLVM counterparts. They are beneficiaries of your work :)

echristo accepted this revision.Jun 27 2018, 1:48 PM

Oh, sure :)

Closed by commit rL335785: [llvm-objdump] Add -x --all-headers options (authored by MaskRay). · Explain WhyJun 27 2018, 1:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
tools/
llvm-objdump/
1 line
9 lines

Diff 153008

tools/llvm-objdump/llvm-objdump.h

Show All 26 Linesnamespace object {
class RelocationRef; class RelocationRef;
} }
extern cl::opt<std::string> TripleName; extern cl::opt<std::string> TripleName;
extern cl::opt<std::string> ArchName; extern cl::opt<std::string> ArchName;
extern cl::opt<std::string> MCPU; extern cl::opt<std::string> MCPU;
extern cl::list<std::string> MAttrs; extern cl::list<std::string> MAttrs;
extern cl::list<std::string> FilterSections; extern cl::list<std::string> FilterSections;
extern cl::opt<bool> AllHeaders;
extern cl::opt<bool> Disassemble; extern cl::opt<bool> Disassemble;
extern cl::opt<bool> DisassembleAll; extern cl::opt<bool> DisassembleAll;
extern cl::opt<bool> NoShowRawInsn; extern cl::opt<bool> NoShowRawInsn;
extern cl::opt<bool> NoLeadingAddr; extern cl::opt<bool> NoLeadingAddr;
extern cl::opt<bool> PrivateHeaders; extern cl::opt<bool> PrivateHeaders;
extern cl::opt<bool> FirstPrivateHeader; extern cl::opt<bool> FirstPrivateHeader;
extern cl::opt<bool> ExportsTrie; extern cl::opt<bool> ExportsTrie;
extern cl::opt<bool> Rebase; extern cl::opt<bool> Rebase;
▲ Show 20 Lines • Show All 72 Lines • Show Last 20 Lines

tools/llvm-objdump/llvm-objdump.cpp

Show First 20 Lines • Show All 61 Lines • ▼ Show 20 Lines
#include <cstring> #include <cstring>
#include <system_error> #include <system_error>
#include <unordered_map> #include <unordered_map>
#include <utility> #include <utility>
using namespace llvm; using namespace llvm;
using namespace object; using namespace object;
cl::opt<bool>
llvm::AllHeaders("all-headers",
cl::desc("Display all available header information"));
static cl::alias AllHeadersShort("x", cl::desc("Alias for --all-headers"),
cl::aliasopt(AllHeaders));
static cl::list<std::string> static cl::list<std::string>
InputFilenames(cl::Positional, cl::desc("<input object files>"),cl::ZeroOrMore); InputFilenames(cl::Positional, cl::desc("<input object files>"),cl::ZeroOrMore);
cl::opt<bool> cl::opt<bool>
llvm::Disassemble("disassemble", llvm::Disassemble("disassemble",
cl::desc("Display assembler mnemonics for the machine instructions")); cl::desc("Display assembler mnemonics for the machine instructions"));
static cl::alias static cl::alias
Disassembled("d", cl::desc("Alias for --disassemble"), Disassembled("d", cl::desc("Alias for --disassemble"),
▲ Show 20 Lines • Show All 2,151 Lines • ▼ Show 20 Linesint main(int argc, char **argv) {
TripleName = Triple::normalize(TripleName); TripleName = Triple::normalize(TripleName);
ToolName = argv[0]; ToolName = argv[0];
// Defaults to a.out if no filenames specified. // Defaults to a.out if no filenames specified.
if (InputFilenames.size() == 0) if (InputFilenames.size() == 0)
InputFilenames.push_back("a.out"); InputFilenames.push_back("a.out");
if (AllHeaders)
PrivateHeaders = Relocations = SectionHeaders = SymbolTable = true;
if (DisassembleAll || PrintSource || PrintLines) if (DisassembleAll || PrintSource || PrintLines)
Disassemble = true; Disassemble = true;
if (!Disassemble if (!Disassemble
&& !Relocations && !Relocations
&& !DynamicRelocations && !DynamicRelocations
&& !SectionHeaders && !SectionHeaders
&& !SectionContents && !SectionContents
&& !SymbolTable && !SymbolTable
Show All 32 Lines