[llvm-objdump] Add -x --all-headers options

[paulsemel]

It seems to be displaying the correct information.
I just noticed that we are not printing dynamic section in the -private-headers option, this might somehow be fixed.

LGTM, but please, wait for @echristo approval :)

[MaskRay]

In D48622#1144670, @paulsemel wrote:

It seems to be displaying the correct information.
I just noticed that we are not printing dynamic section in the -private-headers option, this might somehow be fixed.

LGTM, but please, wait for @echristo approval :)

We also lack -a (--archive-headers) and -f (--file-headers) :)

[paulsemel]

In D48622#1145147, @MaskRay wrote:

In D48622#1144670, @paulsemel wrote:

It seems to be displaying the correct information.
I just noticed that we are not printing dynamic section in the -private-headers option, this might somehow be fixed.

LGTM, but please, wait for @echristo approval :)

We also lack -a (--archive-headers) and -f (--file-headers) :)

That's right, I will take a look at it when I have more time, thanks a lot ! :)

[MaskRay]

In D48622#1145608, @paulsemel wrote:

In D48622#1145147, @MaskRay wrote:

In D48622#1144670, @paulsemel wrote:

It seems to be displaying the correct information.
I just noticed that we are not printing dynamic section in the -private-headers option, this might somehow be fixed.

LGTM, but please, wait for @echristo approval :)

We also lack -a (--archive-headers) and -f (--file-headers) :)

That's right, I will take a look at it when I have more time, thanks a lot ! :)

And FYI https://lists.freebsd.org/pipermail/freebsd-toolchain/2018-June/003809.html FreeBSD devs are moving away from GNU binutils and migrating to LLVM counterparts. They are beneficiaries of your work :)

[echristo]

Oh, sure :)

llvm/trunk/tools/llvm-objdump/llvm-objdump.h

namespace object {
   class RelocationRef;
 }
 
 extern cl::opt<std::string> TripleName;
 extern cl::opt<std::string> ArchName;
 extern cl::opt<std::string> MCPU;
 extern cl::list<std::string> MAttrs;
 extern cl::list<std::string> FilterSections;
+extern cl::opt<bool> AllHeaders;
 extern cl::opt<bool> Disassemble;
 extern cl::opt<bool> DisassembleAll;
 extern cl::opt<bool> NoShowRawInsn;
 extern cl::opt<bool> NoLeadingAddr;
 extern cl::opt<bool> PrivateHeaders;
 extern cl::opt<bool> FirstPrivateHeader;
 extern cl::opt<bool> ExportsTrie;
 extern cl::opt<bool> Rebase;

llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp

 #include <cstring>
 #include <system_error>
 #include <unordered_map>
 #include <utility>
 
 using namespace llvm;
 using namespace object;
 
+cl::opt<bool>
+    llvm::AllHeaders("all-headers",
+                     cl::desc("Display all available header information"));
+static cl::alias AllHeadersShort("x", cl::desc("Alias for --all-headers"),
+                                 cl::aliasopt(AllHeaders));
+
 static cl::list<std::string>
 InputFilenames(cl::Positional, cl::desc("<input object files>"),cl::ZeroOrMore);
 
 cl::opt<bool>
 llvm::Disassemble("disassemble",
   cl::desc("Display assembler mnemonics for the machine instructions"));
 static cl::alias
 Disassembled("d", cl::desc("Alias for --disassemble"),
int main(int argc, char **argv) {
   TripleName = Triple::normalize(TripleName);
 
   ToolName = argv[0];
 
   // Defaults to a.out if no filenames specified.
   if (InputFilenames.size() == 0)
     InputFilenames.push_back("a.out");
 
+  if (AllHeaders)
+    PrivateHeaders = Relocations = SectionHeaders = SymbolTable = true;
+
   if (DisassembleAll || PrintSource || PrintLines)
     Disassemble = true;
   if (!Disassemble
       && !Relocations
       && !DynamicRelocations
       && !SectionHeaders
       && !SectionContents
       && !SymbolTable