Page MenuHomePhabricator

ConstantFold: Don't fold global address vs. null for addrspace != 0
ClosedPublic

Authored by arsenm on Jun 26 2018, 1:52 AM.

Details

Reviewers
efriedma
Summary

Not sure why this logic seems to be repeated in 2 different places,
one called by the other.

On AMDGPU addrspace(3) globals start allocating at 0, so these
checks will be incorrect (not that real code actually tries
to compare these addresses)

Diff Detail

Event Timeline

arsenm created this revision.Jun 26 2018, 1:52 AM
efriedma accepted this revision.Jun 26 2018, 11:24 AM
efriedma added a subscriber: manojgupta.

LGTM

This revision is now accepted and ready to land.Jun 26 2018, 11:24 AM
arsenm closed this revision.Jun 26 2018, 12:00 PM

r335649

LGTM

Thanks, updated D47895 to include these.