Page MenuHomePhabricator

[analyzer] Add support for std::basic_string::data() in DanglingInternalBufferChecker
ClosedPublic

Authored by rnkovacs on Jun 25 2018, 1:01 AM.

Diff Detail

Repository
rC Clang

Event Timeline

rnkovacs created this revision.Jun 25 2018, 1:01 AM
This revision is now accepted and ready to land.Jun 25 2018, 8:42 AM
xazax.hun added inline comments.Jun 25 2018, 8:47 AM
test/Analysis/dangling-internal-buffer.cpp
10

Note that these methods are const according to the standard. Even if it does not make any difference for this check we should follow the signatures. Also, from c++17 there is a non-const overload of data.

rnkovacs updated this revision to Diff 152737.Jun 25 2018, 11:52 AM
rnkovacs marked an inline comment as done.
rnkovacs added inline comments.
test/Analysis/dangling-internal-buffer.cpp
10

Oh, right, thanks. Fixed here and in D48522.

This revision was automatically updated to reflect the committed changes.