This is an archive of the discontinued LLVM Phabricator instance.

[Driver] Make scudo compatible with -fsanitize-minimal-runtime
ClosedPublic

Authored by cryptoad on Jun 20 2018, 8:42 AM.

Details

Summary

This is the clang side of the change, there is a compiler-rt counterpart.

Scudo works with UBSan using -fsanitize=scudo,integer for example, and to do
so it embeds UBSan runtime. This makes it not compatible with the UBSan minimal
runtime, but this is something we want for production purposes.

The idea is to have a Scudo minimal runtime on the compiler-rt side that will
not embed UBSan. This is basically the runtime that is currently in use for
Fuchsia, without coverage, stacktraces or symbolization. With this, Scudo
becomes compatible with -fsanitize-minimal-runtime.

If this approach is suitable, I'll add the tests as well, otherwise I am open
to other options.

Diff Detail

Event Timeline

cryptoad created this revision.Jun 20 2018, 8:42 AM
eugenis accepted this revision.Jun 20 2018, 12:28 PM
This revision is now accepted and ready to land.Jun 20 2018, 12:28 PM
eugenis requested changes to this revision.Jun 20 2018, 12:28 PM

Please add a test.

This revision now requires changes to proceed.Jun 20 2018, 12:28 PM
cryptoad updated this revision to Diff 152171.Jun 20 2018, 2:32 PM

Adding tests.

eugenis accepted this revision.Jun 20 2018, 2:40 PM

Looks great, thanks!

This revision is now accepted and ready to land.Jun 20 2018, 2:40 PM
This revision was automatically updated to reflect the committed changes.