Revert "[lldb-mi] Add overload method for setting an error"

[apolyakov]

Summary

This reverts commit r334245 because it duplicates functionality of Status::AsCString used in SBError.

[clayborg]

I didn't remember we already did this in SBError... Sorry about that.

lldb/trunk/tools/lldb-mi/MICmdBase.h

 //===-- MICmdBase.h ---------------------------------------------*- C++ -*-===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
 #pragma once
 
 // C Includes
 // C++ Includes
 // Other libraries and framework includes
-#include "lldb/API/SBError.h"
-
 // Project includes
 #include "MICmdArgSet.h"
 #include "MICmdData.h"
 #include "MICmdFactory.h"
 #include "MICmdInvoker.h"
 #include "MICmnBase.h"
 #include "MICmnMIResultRecord.h"
 #include "MICmnResources.h"
public:
 
   // Overrideable:
   ~CMICmdBase() override;
   virtual bool GetExitAppOnCommandFailure() const;
 
   // Methods:
 protected:
   void SetError(const CMIUtilString &rErrMsg);
-  void SetError(const lldb::SBError &error);
   template <class T> T *GetOption(const CMIUtilString &vStrOptionName);
   bool ParseValidateCmdOptions();
 
   // Attributes:
   CMICmdFactory::CmdCreatorFnPtr m_pSelfCreatorFn;
   CMIUtilString m_strCurrentErrDescription; // Reason for Execute or Acknowledge
                                             // function failure
   SMICmdData m_cmdData; // Holds information/status of *this command. Used by

lldb/trunk/tools/lldb-mi/MICmdBase.cpp

const CMICmnMIResultRecord miResultRecord(
       m_cmdData.strMiCmdToken, CMICmnMIResultRecord::eResultClass_Error,
       valueResult);
   m_miResultRecord = miResultRecord;
   m_cmdData.strMiCmdResultRecord = miResultRecord.GetString();
 }
 
 //++
 //------------------------------------------------------------------------------------
-// Details: Short cut function to enter error information into the command's
-//          metadata object and set the command's error status.
-// Type:    Method.
-// Args:    error - (R) Command result description.
-// Return:  None.
-// Throws:  None.
-//--
-void CMICmdBase::SetError(const lldb::SBError &error) {
-  const char *error_cstr = error.GetCString();
-  if (error_cstr)
-    SetError(error_cstr);
-  else
-    SetError("unknown error");
-}
-
-//++
-//------------------------------------------------------------------------------------
 // Details: Ask a command to provide its unique identifier.
 // Type:    Method.
 // Args:    A unique identifier for this command class.
 // Return:  None.
 // Throws:  None.
 //--
 MIuint CMICmdBase::GetGUID() {
   MIuint64 vptr = reinterpret_cast<MIuint64>(this);