Page MenuHomePhabricator

Handle an Xcode path with spaces in it
ClosedPublic

Authored by jordan_rose on Jun 12 2018, 4:57 PM.

Details

Summary

These two changes make it possible to build on macOS where the path to Xcode includes spaces. I don't expect people to not break this, but there seems to be no harm in taking it.

Diff Detail

Repository
rL LLVM

Event Timeline

jordan_rose created this revision.Jun 12 2018, 4:57 PM
This revision is now accepted and ready to land.Jun 13 2018, 9:59 AM
kubamracek accepted this revision.Jun 13 2018, 10:05 AM

Thanks!

jordan_rose closed this revision.Jun 13 2018, 11:29 AM

Landed in rL334632. Turns out the iOS.cmake part has been refactored since the version I was looking at (Swift 4.2's branch of LLVM), and so this was just the libtool change.