Page MenuHomePhabricator

[AMDGPU] DAG combine to produce V_PERM_B32
ClosedPublic

Authored by rampitec on Jun 12 2018, 2:45 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

rampitec created this revision.Jun 12 2018, 2:45 PM
msearles accepted this revision.Jun 12 2018, 3:46 PM

LGTM; couple of minor nits on couple of comments

lib/Target/AMDGPU/SIISelLowering.cpp
6323 ↗(On Diff #151037)

s/less/fewer: 'to have fewer unique masks'
typo; s/less/fewer: 'and therefore fewer registers used to hold the masks.'

6420 ↗(On Diff #151037)

s/less/fewer: 'to have fewer unique masks'
typo; s/less/fewer: 'and therefore fewer registers used to hold the masks.'

This revision is now accepted and ready to land.Jun 12 2018, 3:46 PM
rampitec updated this revision to Diff 151065.Jun 12 2018, 4:23 PM
rampitec marked 2 inline comments as done.

Changed comments as requested.

This revision was automatically updated to reflect the committed changes.