This is an archive of the discontinued LLVM Phabricator instance.

Differential D48073

[MachO] Add lldCommon to LINK_LIBS
AbandonedPublic

Authored by aheejin on Jun 12 2018, 4:17 AM.

Details

Reviewers
modocache
Summary

After D47998 (rL334466), this is necessary to make this build with
-DSHARED_LIBS=ON flag.

Diff Detail

Event Timeline

aheejin created this revision.Jun 12 2018, 4:17 AM
Harbormaster completed remote builds in B19226: Diff 150927.Jun 12 2018, 4:17 AM
Herald added subscribers: llvm-commits, mgorny. · View Herald TranscriptJun 12 2018, 4:17 AM
modocache accepted this revision.Jun 12 2018, 4:41 AM

Thanks for catching this! LGTM.

This revision is now accepted and ready to land.Jun 12 2018, 4:41 AM
aheejin abandoned this revision.Jun 12 2018, 9:16 AM

Looks like the same thing already landed in rL334507.

Revision Contents

PathSize
lib/
ReaderWriter/
MachO/
1 line

Diff 150927

lib/ReaderWriter/MachO/CMakeLists.txt

Show All 20 Linesadd_lld_library(lldMachO
LINK_COMPONENTS LINK_COMPONENTS
DebugInfoDWARF DebugInfoDWARF
Demangle Demangle
Object Object
Support Support
LINK_LIBS LINK_LIBS
lldCommon
lldCore lldCore
lldYAML lldYAML
${LLVM_PTHREAD_LIB} ${LLVM_PTHREAD_LIB}
) )
include_directories(.) include_directories(.)