This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Add tests for overflow intrinsics
ClosedPublic

Authored by rogfer01 on Jun 7 2018, 10:28 PM.

Details

Summary

This is using the existing codegen so we can see the change once we custom lower ISD::{U,S}{ADD,SUB}O nodes.

Diff Detail

Event Timeline

rogfer01 created this revision.Jun 7 2018, 10:28 PM
asb accepted this revision.Jun 14 2018, 6:58 AM

Thanks! Looks good to me, but two minor suggestions:

  • arith-with-overflow.ll might be a better name
  • Add the nounwind attribute to the function definitions, so we still get clean assembly output when cfi directives are emitted.
This revision is now accepted and ready to land.Jun 14 2018, 6:58 AM
rogfer01 updated this revision to Diff 151853.Jun 18 2018, 11:48 PM

Thanks for the review @asb !

Updated the diff with your suggestions.

rogfer01 closed this revision.Jun 18 2018, 11:52 PM

Oops, I forgot to add the Differential URL in the commit.

Submitted in rL335023: [RISCV] Add tests for overflow intrinsics