Page MenuHomePhabricator

[ARM] Allow CMPZ transforms even if the input has multiple uses.
ClosedPublic

Authored by efriedma on Jun 7 2018, 6:55 PM.

Details

Summary

It looks like this got left in by accident in r289794; I can't think of any reason the check would be necessary. (Maybe it was meant to be a check that the AND has one use? But we check that a few lines earlier.)

Diff Detail

Repository
rL LLVM

Event Timeline

efriedma created this revision.Jun 7 2018, 6:55 PM
SjoerdMeijer accepted this revision.Jun 8 2018, 12:47 AM

The initial commit showed problem in testing, and my fix added the check that the AND has a single use. Looks like indeed that we just forgot to remove the other check as I also don't see why it would be necessary. Thanks for fixing.

This revision is now accepted and ready to land.Jun 8 2018, 12:47 AM
This revision was automatically updated to reflect the committed changes.

Showed some decent improvements in a few benchmarks. Cheers.

The initial commit showed problem in testing, and my fix added the check that the AND has a single use. Looks like indeed that we just forgot to remove the other check as I also don't see why it would be necessary. Thanks for fixing.

The initial commit showed problem in testing, and my fix added the check that the AND has a single use. Looks like indeed that we just forgot to remove the other check as I also don't see why it would be necessary. Thanks for fixing.