This is an archive of the discontinued LLVM Phabricator instance.

Differential D47803

Add definition for ELF dynamic tag DT_SYMTAB_SHNDX.
ClosedPublic

Authored by rahulchaudhry on Jun 5 2018, 4:42 PM.

Details

Reviewers
pcc
Commits
rGac0f5cf74b4d: Add definition for ELF dynamic tag DT_SYMTAB_SHNDX.
rL334149: Add definition for ELF dynamic tag DT_SYMTAB_SHNDX.
Summary

DT_SYMTAB_SHNDX is defined in generic-abi:

Diff Detail

Event Timeline

rahulchaudhry created this revision.Jun 5 2018, 4:42 PM
Herald added a subscriber: llvm-commits. · View Herald TranscriptJun 5 2018, 4:42 PM
Harbormaster completed remote builds in B18975: Diff 150057.Jun 5 2018, 4:42 PM
pcc accepted this revision.Jun 5 2018, 7:03 PM

LGTM

This revision is now accepted and ready to land.Jun 5 2018, 7:03 PM
rahulchaudhry added a comment.Jun 5 2018, 9:59 PM

Can you land it as well. I am new to llvm and don't have commit access.
Thanks.

Closed by commit rL334149: Add definition for ELF dynamic tag DT_SYMTAB_SHNDX. (authored by pcc). · Explain WhyJun 6 2018, 5:12 PM
This revision was automatically updated to reflect the committed changes.
grimar added a subscriber: grimar.Jun 18 2018, 3:03 AM

I think this needs a test.

Revision Contents

PathSize
include/
llvm/
BinaryFormat/
2 lines

Diff 150057

include/llvm/BinaryFormat/DynamicTags.def

Show First 20 Lines • Show All 57 Lines • ▼ Show 20 Lines
DYNAMIC_TAG(RUNPATH, 29) // String table offset of lib search path. DYNAMIC_TAG(RUNPATH, 29) // String table offset of lib search path.
DYNAMIC_TAG(FLAGS, 30) // Flags. DYNAMIC_TAG(FLAGS, 30) // Flags.
DYNAMIC_TAG_MARKER(ENCODING, 32) // Values from here to DT_LOOS follow the rules DYNAMIC_TAG_MARKER(ENCODING, 32) // Values from here to DT_LOOS follow the rules
// for the interpretation of the d_un union. // for the interpretation of the d_un union.
DYNAMIC_TAG(PREINIT_ARRAY, 32) // Pointer to array of preinit functions. DYNAMIC_TAG(PREINIT_ARRAY, 32) // Pointer to array of preinit functions.
DYNAMIC_TAG(PREINIT_ARRAYSZ, 33) // Size of the DT_PREINIT_ARRAY array. DYNAMIC_TAG(PREINIT_ARRAYSZ, 33) // Size of the DT_PREINIT_ARRAY array.
DYNAMIC_TAG(SYMTAB_SHNDX, 34) // Address of the SHT_SYMTAB_SHNDX section.
DYNAMIC_TAG_MARKER(LOOS, 0x60000000) // Start of environment specific tags. DYNAMIC_TAG_MARKER(LOOS, 0x60000000) // Start of environment specific tags.
DYNAMIC_TAG_MARKER(HIOS, 0x6FFFFFFF) // End of environment specific tags. DYNAMIC_TAG_MARKER(HIOS, 0x6FFFFFFF) // End of environment specific tags.
DYNAMIC_TAG_MARKER(LOPROC, 0x70000000) // Start of processor specific tags. DYNAMIC_TAG_MARKER(LOPROC, 0x70000000) // Start of processor specific tags.
DYNAMIC_TAG_MARKER(HIPROC, 0x7FFFFFFF) // End of processor specific tags. DYNAMIC_TAG_MARKER(HIPROC, 0x7FFFFFFF) // End of processor specific tags.
// Android packed relocation section tags. // Android packed relocation section tags.
// https://android.googlesource.com/platform/bionic/+/6f12bfece5dcc01325e0abba56a46b1bcf991c69/tools/relocation_packer/src/elf_file.cc#31 // https://android.googlesource.com/platform/bionic/+/6f12bfece5dcc01325e0abba56a46b1bcf991c69/tools/relocation_packer/src/elf_file.cc#31
DYNAMIC_TAG(ANDROID_REL, 0x6000000F) DYNAMIC_TAG(ANDROID_REL, 0x6000000F)
▲ Show 20 Lines • Show All 129 Lines • Show Last 20 Lines