This is an archive of the discontinued LLVM Phabricator instance.

llvm-readobj: fix printing number of relocations in Android packed format.
ClosedPublic

Authored by rahulchaudhry on Jun 5 2018, 2:27 PM.

Details

Summary

With '-elf-output-style=GNU -relocations', a header containing the number
of entries is printed before all the relocation entries in the section.
For Android packed format, we need to perform the unpacking first before
we can get the actual number of relocations in the section.

Diff Detail

Event Timeline

rahulchaudhry created this revision.Jun 5 2018, 2:27 PM
pcc accepted this revision.Jun 5 2018, 2:40 PM

LGTM

tools/llvm-readobj/ELFDumper.cpp
2644

Rename AndroidRelas to match the surrounding code.

This revision is now accepted and ready to land.Jun 5 2018, 2:40 PM

Renamed android_relas -> AndroidRelas

rahulchaudhry marked an inline comment as done.Jun 5 2018, 2:46 PM

Thanks for the review.
Can you land this one as well. I am new to llvm and don't have commit access.

This revision was automatically updated to reflect the committed changes.