Page MenuHomePhabricator

[mips] Correct the predicates for a number of codegen only instructions
ClosedPublic

Authored by sdardis on Jun 1 2018, 8:20 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

sdardis created this revision.Jun 1 2018, 8:20 AM

Looks okay, you could add a test case if you feel the change requires it.

This particular case is not quite testable, as GPR64s are only available when we have 64 bit registers. Adding GPR_64 predicates to these instructions is somewhat overkill, but does simplify fixing up the scheduler models later.

smaksimovic accepted this revision.Jun 6 2018, 10:36 AM

In that case LGTM.

This revision is now accepted and ready to land.Jun 6 2018, 10:36 AM
This revision was automatically updated to reflect the committed changes.