This is an archive of the discontinued LLVM Phabricator instance.

[ELF] Remove redundant use of -m/-triple in test files. NFC.
ClosedPublic

Authored by sbc100 on May 29 2018, 10:02 PM.

Details

Summary

This makes the tests slightly easier to maintain and compare
with the equivalent tests under for other platforms.

Diff Detail

Repository
rL LLVM

Event Timeline

sbc100 created this revision.May 29 2018, 10:02 PM
sbc100 added a reviewer: pcc.May 29 2018, 10:03 PM
pcc added a comment.May 29 2018, 10:06 PM

I don't think you can drop use of -triple because that would cause llvm-mc to default to the host triple, which would mean that the tests would start failing on non-ELF platforms.

Dropping the -m seems reasonable to me though.

sbc100 updated this revision to Diff 149157.May 30 2018, 10:28 AM
  • feedback
pcc accepted this revision.May 30 2018, 10:39 AM

LGTM

This revision is now accepted and ready to land.May 30 2018, 10:39 AM
This revision was automatically updated to reflect the committed changes.