Page MenuHomePhabricator

[LowerTypeTests] Discard extern_weak linkage for definitions
ClosedPublic

Authored by vlad.tsyrklevich on May 29 2018, 1:03 PM.

Details

Summary

Fix PR37625. It's possible for an extern_weak declaration to be emitted
to the merged module when a definition exists in the ThinLTO portion of
the build; discard the linkage on the declaration in that case.
(otherwise we copy the linkage to the alias to the jumptable and fail)

Diff Detail

Repository
rL LLVM

Event Timeline

pcc accepted this revision.May 29 2018, 3:15 PM

LGTM

This revision is now accepted and ready to land.May 29 2018, 3:15 PM
This revision was automatically updated to reflect the committed changes.