Page MenuHomePhabricator

Make getStrictFPOpcodeAction(...) more accessible
ClosedPublic

Authored by cameron.mcinally on May 25 2018, 11:01 AM.

Details

Summary

This NFCI patch moves a static helper function into the TargetLoweringInfo class, so that it can be reused by other classes. I intend to call this new function, called getStrictOperationAction(...), from VectorLegalizer in the near future.

Diff Detail

Repository
rL LLVM

Event Timeline

kpn added a subscriber: kpn.May 29 2018, 7:13 AM

Is there a reason for dropping the "FP" from "StrictFP" in the method name? I think it would be better to keep it (i.e. use "getStrictFPOperationAction"), in particular since there are already other public methods in this area that use "StrictFP", like isStrictFPOpcode and MutateStrictFPToFP.

Otherwise this LGTM.

Is there a reason for dropping the "FP" from "StrictFP" in the method name?

Ah, no. It was a typo when I changed "Opcode"->"Operation". I'll update and submit the patch. Thanks, Ulrich.

Rename "getStrictOperationAction" to "getStrictFPOperationAction".

This revision was not accepted when it landed; it landed in state Needs Review.May 29 2018, 9:53 AM
Closed by commit rL333433: [StrictFP] Make getStrictFPOpcodeAction(...) more accessible (authored by mcinally, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.