Page MenuHomePhabricator

[X86] Remove some preprocessor feature checks from intrinsic headers
ClosedPublic

Authored by craig.topper on May 17 2018, 12:59 PM.

Details

Summary

These look to be a couple things that weren't remvoed when we switched to target attribute.

The popcnt makes including just smmintrin.h also include popcntintrin.h. The popcnt file itself already contains target attrributes.

The prefetch ones are just wrappers around __builtin_prefetch which we have graceful fallbacks for in the backend if the exact instruction isn't available. So there's no reason to hide them. And it makes them available in functions that have the write target attribute but not a -march command line flag.

Diff Detail

Repository
rC Clang

Event Timeline

craig.topper created this revision.May 17 2018, 12:59 PM

Looks right to me, Craig.

echristo accepted this revision.May 20 2018, 5:55 PM

LGTM.

-eric

This revision is now accepted and ready to land.May 20 2018, 5:55 PM
This revision was automatically updated to reflect the committed changes.