This is an archive of the discontinued LLVM Phabricator instance.

Differential D47029

[X86] Remove some preprocessor feature checks from intrinsic headers
ClosedPublic

Authored by craig.topper on May 17 2018, 12:59 PM.

Details

Reviewers
echristo
RKSimon
spatel
DavidKreitzer
Commits
rG092d42557b6c: [X86] Remove some preprocessor feature checks from intrinsic headers
rL332830: [X86] Remove some preprocessor feature checks from intrinsic headers
rC332830: [X86] Remove some preprocessor feature checks from intrinsic headers
Summary

These look to be a couple things that weren't remvoed when we switched to target attribute.

The popcnt makes including just smmintrin.h also include popcntintrin.h. The popcnt file itself already contains target attrributes.

The prefetch ones are just wrappers around __builtin_prefetch which we have graceful fallbacks for in the backend if the exact instruction isn't available. So there's no reason to hide them. And it makes them available in functions that have the write target attribute but not a -march command line flag.

Diff Detail

Repository
rC Clang

Event Timeline

craig.topper created this revision.May 17 2018, 12:59 PM
craig.topper added a reviewer: DavidKreitzer.May 17 2018, 3:33 PM
DavidKreitzer added a comment.May 18 2018, 2:41 PM

Looks right to me, Craig.

echristo accepted this revision.May 20 2018, 5:55 PM

LGTM.

-eric

This revision is now accepted and ready to land.May 20 2018, 5:55 PM
Closed by commit rC332830: [X86] Remove some preprocessor feature checks from intrinsic headers (authored by ctopper). · Explain WhyMay 20 2018, 11:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Headers/
2 lines
2 lines

Diff 147735

lib/Headers/prfchwintrin.h

Show All 22 Lines
#if !defined(__X86INTRIN_H) && !defined(_MM3DNOW_H_INCLUDED) #if !defined(__X86INTRIN_H) && !defined(_MM3DNOW_H_INCLUDED)
#error "Never use <prfchwintrin.h> directly; include <x86intrin.h> or <mm3dnow.h> instead." #error "Never use <prfchwintrin.h> directly; include <x86intrin.h> or <mm3dnow.h> instead."
#endif #endif
#ifndef __PRFCHWINTRIN_H #ifndef __PRFCHWINTRIN_H
#define __PRFCHWINTRIN_H #define __PRFCHWINTRIN_H
#if defined(__PRFCHW__) || defined(__3dNOW__)
/// Loads a memory sequence containing the specified memory address into /// Loads a memory sequence containing the specified memory address into
/// all data cache levels. The cache-coherency state is set to exclusive. /// all data cache levels. The cache-coherency state is set to exclusive.
/// Data can be read from and written to the cache line without additional /// Data can be read from and written to the cache line without additional
/// delay. /// delay.
/// ///
/// \headerfile <x86intrin.h> /// \headerfile <x86intrin.h>
/// ///
/// This intrinsic corresponds to the \c PREFETCHT0 instruction. /// This intrinsic corresponds to the \c PREFETCHT0 instruction.
Show All 21 Lines
/// ///
/// \param __P /// \param __P
/// A pointer specifying the memory address to be prefetched. /// A pointer specifying the memory address to be prefetched.
static __inline__ void __attribute__((__always_inline__, __nodebug__)) static __inline__ void __attribute__((__always_inline__, __nodebug__))
_m_prefetchw(void *__P) _m_prefetchw(void *__P)
{ {
__builtin_prefetch (__P, 1, 3 /* _MM_HINT_T0 */); __builtin_prefetch (__P, 1, 3 /* _MM_HINT_T0 */);
} }
#endif
#endif /* __PRFCHWINTRIN_H */ #endif /* __PRFCHWINTRIN_H */

lib/Headers/smmintrin.h

Show First 20 Lines • Show All 2,452 Lines • ▼ Show 20 Lines
_mm_crc32_u64(unsigned long long __C, unsigned long long __D) _mm_crc32_u64(unsigned long long __C, unsigned long long __D)
{ {
return __builtin_ia32_crc32di(__C, __D); return __builtin_ia32_crc32di(__C, __D);
} }
#endif /* __x86_64__ */ #endif /* __x86_64__ */
#undef __DEFAULT_FN_ATTRS #undef __DEFAULT_FN_ATTRS
#ifdef __POPCNT__
#include <popcntintrin.h> #include <popcntintrin.h>
#endif
#endif /* __SMMINTRIN_H */ #endif /* __SMMINTRIN_H */