This is an archive of the discontinued LLVM Phabricator instance.

Differential D46869

[Polly][arc] Remove unittesting from arcconfig
ClosedPublic

Authored by philip.pfaffe on May 15 2018, 4:12 AM.

Details

Reviewers
grosser
Meinersbur
bollu
Commits
rG8d1ea73d51a6: [arc] Remove unittesting from arcconfig
rPLO332355: [arc] Remove unittesting from arcconfig
rL332355: [arc] Remove unittesting from arcconfig
Summary

Unittests aren't working, and I don't think they ever were. Just remove
them, so that we don't have to write arc --nounit all the time.

Diff Detail

Event Timeline

philip.pfaffe created this revision.May 15 2018, 4:12 AM
Herald added a reviewer: bollu. · View Herald TranscriptMay 15 2018, 4:12 AM
Herald added a subscriber: bollu. · View Herald Transcript
Harbormaster completed remote builds in B18101: Diff 146779.May 15 2018, 4:13 AM
philip.pfaffe updated this revision to Diff 146783.May 15 2018, 4:23 AM

Actually remove unittest driver as well.

To clarify: The unittests that're hooked into arc are based around
make printvars, which is not available anymore since I think 3.9.

Harbormaster completed remote builds in B18102: Diff 146783.May 15 2018, 4:24 AM
grosser accepted this revision.May 15 2018, 5:17 AM

LGTM.

This revision is now accepted and ready to land.May 15 2018, 5:17 AM
Closed by commit rL332355: [arc] Remove unittesting from arcconfig (authored by pfaffe). · Explain WhyMay 15 2018, 6:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
7 lines

Diff 146779

.arcconfig

{ {
"repository.callsign" : "PLO", "repository.callsign" : "PLO",
"conduit_uri" : "https://reviews.llvm.org/", "conduit_uri" : "https://reviews.llvm.org/"
"history.immutable" : true,
"load" : [
"utils/arcanist/LitTestEngine"
],
"unit.engine" : "LitTestEngine"
} }