- In logtest.cpp, the name of the file that is reported is not always capitalized, so split the comparison to validate the file (case insensitive) and function (case sensitive) separately
- Update the gdb remote client tests to work with Python 3. In Python 3, socket sends/receives data as bytes rather than byte strings. This also updates the usage of .hex() - this is no longer available in Python 3, so use hexlify instead
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
packages/Python/lldbsuite/test/functionalities/gdb_remote_client/gdbclientutils.py | ||
---|---|---|
281–285 ↗ | (On Diff #146405) | It's a shame that we're not using lit here. lit has a nice function lit.util.to_string which handles this (and one other strange edge case) correctly. |
389–392 ↗ | (On Diff #146405) | Similarly here. |
packages/Python/lldbsuite/test/functionalities/gdb_remote_client/gdbclientutils.py | ||
---|---|---|
281–285 ↗ | (On Diff #146405) | I looked into using it - but currently none of the lldb tests use functionality from lit and I don't think there's a good way to do so. Let me know if you have a suggestion, but otherwise, I think this is the least impactful change that fixes the tests. |