This is an archive of the discontinued LLVM Phabricator instance.

[IRTests] Verify PDT instead of DT
ClosedPublic

Authored by NutshellySima on May 10 2018, 8:24 AM.

Details

Summary

Fix two typos which result in verifying wrong data structures (DT) instead of PDT in DominatorTreeBatchUpdatesTest.

Diff Detail

Repository
rL LLVM

Event Timeline

NutshellySima created this revision.May 10 2018, 8:24 AM
davide accepted this revision.May 10 2018, 8:30 AM

This looks correct, but I'll let Kuba comment as he wrote this unittest originally.

This revision is now accepted and ready to land.May 10 2018, 8:30 AM

Looks good to me as well. Let's see what Kuba says.

dberlin accepted this revision.May 10 2018, 8:33 AM

I can verify this is correct :)

kuhar accepted this revision.May 10 2018, 8:48 AM

LGTM.

Do you have committ access?

LGTM.

Do you have committ access?

No, I don't.

kuhar added a comment.May 10 2018, 9:14 AM

OK, I'll commit it later.

This revision was automatically updated to reflect the committed changes.