Page MenuHomePhabricator

[lsan] Report unsuspended threads
ClosedPublic

Authored by vitalybuka on May 9 2018, 2:42 PM.

Details

Summary

Leak checker needs to suspend all process threads. If we have some running
thread in registry but not suspended we can have false leak report. So we will
report this case here for future debugging.

Diff Detail

Event Timeline

vitalybuka created this revision.May 9 2018, 2:42 PM
vitalybuka updated this revision to Diff 146010.May 9 2018, 2:50 PM

fix "not found" check

eugenis accepted this revision.May 9 2018, 3:08 PM
eugenis added inline comments.
compiler-rt/lib/lsan/lsan_common.cc
530 ↗(On Diff #146010)

did you mean CheckThreadLocked? No reason to use function overloading here.

This revision is now accepted and ready to land.May 9 2018, 3:08 PM
vitalybuka marked an inline comment as done.May 9 2018, 3:16 PM
vitalybuka added inline comments.
compiler-rt/lib/lsan/lsan_common.cc
530 ↗(On Diff #146010)

Oh, sure.

vitalybuka edited the summary of this revision. (Show Details)May 9 2018, 3:17 PM
vitalybuka updated this revision to Diff 146015.May 9 2018, 3:20 PM
vitalybuka marked an inline comment as done.

better naming

This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: Restricted Project. · View Herald TranscriptMay 9 2018, 4:05 PM