This is an archive of the discontinued LLVM Phabricator instance.

[X86] ptwrite intrinsic
ClosedPublic

Authored by GBuella on May 7 2018, 11:43 AM.

Diff Detail

Event Timeline

GBuella created this revision.May 7 2018, 11:43 AM
craig.topper added inline comments.
lib/Target/X86/X86.td
641

does Tremont have PTWrite?

GBuella added inline comments.May 7 2018, 12:12 PM
lib/Target/X86/X86.td
641

Oh, it does indeed.

GBuella updated this revision to Diff 145516.May 7 2018, 12:23 PM

Rearranged proc features in X86.td

GBuella marked 2 inline comments as done.May 7 2018, 12:24 PM
RKSimon added inline comments.May 7 2018, 12:28 PM
lib/Target/X86/X86.td
623

Just put FeaturePTWRITE here?

test/CodeGen/X86/ptwrite-intrinsic-x86.ll
2

Possibly test all the i32 versions here on both x86/x64 and just test the i64 versions in the x86_64.ll file.

12

Can you add tests for the reg-reg version as well?

craig.topper added inline comments.May 7 2018, 12:30 PM
lib/Target/X86/X86.td
623

It's not on GLM. Just GLP and Tremont.

GBuella updated this revision to Diff 145679.May 8 2018, 6:20 AM
craig.topper added inline comments.May 8 2018, 8:39 AM
test/CodeGen/X86/ptwrite-intrinsic-x86.ll
12

I see this is fixed now, but not the comment above?

GBuella updated this revision to Diff 145923.May 9 2018, 7:56 AM
RKSimon accepted this revision.May 9 2018, 8:32 AM

LGTM with one minor

lib/Target/X86/X86InstrSystem.td
691

Possibly add an extra description (as discussed on D46540) here:

// PTWRITE Instruction - Write Processor Trace (PTW) Packet
This revision is now accepted and ready to land.May 9 2018, 8:32 AM
GBuella updated this revision to Diff 146077.May 10 2018, 12:16 AM
GBuella marked an inline comment as done.
This revision was automatically updated to reflect the committed changes.