This is an archive of the discontinued LLVM Phabricator instance.

[llvm-rc] Implement the BITMAP resource type
ClosedPublic

Authored by mstorsjo on May 6 2018, 2:37 PM.

Diff Detail

Event Timeline

mstorsjo created this revision.May 6 2018, 2:37 PM
zturner accepted this revision.May 7 2018, 10:20 AM
zturner added inline comments.
tools/llvm-rc/ResourceFileWriter.cpp
705

Can you add a line above this constexpr size_t BITMAPFILEHEADER_size = 14; and then use this here and below?

This revision is now accepted and ready to land.May 7 2018, 10:20 AM
mstorsjo added inline comments.May 7 2018, 11:07 AM
tools/llvm-rc/ResourceFileWriter.cpp
705

Sure, will do.

amccarth added inline comments.May 7 2018, 11:27 AM
tools/llvm-rc/ResourceFileWriter.cpp
708

Is alignment already guaranteed here?

mstorsjo added inline comments.May 7 2018, 1:20 PM
tools/llvm-rc/ResourceFileWriter.cpp
708

Yes; this is called from writeResource, which aligns the stream before writing the resource header, and then calls this.

amccarth accepted this revision.May 7 2018, 1:21 PM
This revision was automatically updated to reflect the committed changes.