mnbvmar (Marek Sokołowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 6 2016, 11:42 AM (136 w, 1 d)

Recent Activity

Sep 29 2017

mnbvmar committed rL314578: [llvm-rc] Serialize DIALOG(EX) to .res files (serialization, pt 4)..
[llvm-rc] Serialize DIALOG(EX) to .res files (serialization, pt 4).
Sep 29 2017, 5:40 PM
mnbvmar closed D37862: [llvm-rc] Serialize DIALOG(EX) resources to .res files (serialization, pt 4). by committing rL314578: [llvm-rc] Serialize DIALOG(EX) to .res files (serialization, pt 4)..
Sep 29 2017, 5:40 PM
mnbvmar committed rL314562: [llvm-rc] Serialize MENU resources to .res files (serialization, pt 3)..
[llvm-rc] Serialize MENU resources to .res files (serialization, pt 3).
Sep 29 2017, 3:26 PM
mnbvmar closed D37828: [llvm-rc] Serialize MENU resources to .res files (serialization, pt 3). by committing rL314562: [llvm-rc] Serialize MENU resources to .res files (serialization, pt 3)..
Sep 29 2017, 3:26 PM
mnbvmar added a dependency for D38432: [llvm-rc] Support UTF inputs.: D38429: [llvm-rc] Add directory lookup support (serialization, pt 11)..
Sep 29 2017, 3:10 PM
mnbvmar added a dependent revision for D38429: [llvm-rc] Add directory lookup support (serialization, pt 11).: D38432: [llvm-rc] Support UTF inputs..
Sep 29 2017, 3:10 PM
mnbvmar created D38432: [llvm-rc] Support UTF inputs..
Sep 29 2017, 3:10 PM
mnbvmar added a dependency for D38429: [llvm-rc] Add directory lookup support (serialization, pt 11).: D38426: [llvm-rc] Implement escape sequences in .rc files (serialization, pt 10)..
Sep 29 2017, 2:45 PM
mnbvmar added a dependent revision for D38426: [llvm-rc] Implement escape sequences in .rc files (serialization, pt 10).: D38429: [llvm-rc] Add directory lookup support (serialization, pt 11)..
Sep 29 2017, 2:45 PM
mnbvmar created D38429: [llvm-rc] Add directory lookup support (serialization, pt 11)..
Sep 29 2017, 2:44 PM
mnbvmar added a dependency for D38426: [llvm-rc] Implement escape sequences in .rc files (serialization, pt 10).: D38423: [llvm-rc] Serialize user-defined resources to .res files (serialization, pt 9)..
Sep 29 2017, 1:37 PM
mnbvmar added a dependent revision for D38423: [llvm-rc] Serialize user-defined resources to .res files (serialization, pt 9).: D38426: [llvm-rc] Implement escape sequences in .rc files (serialization, pt 10)..
Sep 29 2017, 1:37 PM
mnbvmar created D38426: [llvm-rc] Implement escape sequences in .rc files (serialization, pt 10)..
Sep 29 2017, 1:36 PM
mnbvmar added a dependent revision for D38420: [llvm-rc] Serialize STRINGTABLE statements to .res files (serialization, pt 8).: D38423: [llvm-rc] Serialize user-defined resources to .res files (serialization, pt 9)..
Sep 29 2017, 12:55 PM
mnbvmar added a dependency for D38423: [llvm-rc] Serialize user-defined resources to .res files (serialization, pt 9).: D38420: [llvm-rc] Serialize STRINGTABLE statements to .res files (serialization, pt 8)..
Sep 29 2017, 12:55 PM
mnbvmar added a reviewer for D38423: [llvm-rc] Serialize user-defined resources to .res files (serialization, pt 9).: zturner.
Sep 29 2017, 12:55 PM
mnbvmar created D38423: [llvm-rc] Serialize user-defined resources to .res files (serialization, pt 9)..
Sep 29 2017, 12:54 PM
mnbvmar added a dependent revision for D38410: [llvm-rc] Dump VERSIONINFO resources to .res files (serialization, pt 7). : D38420: [llvm-rc] Serialize STRINGTABLE statements to .res files (serialization, pt 8)..
Sep 29 2017, 12:32 PM
mnbvmar added a dependency for D38420: [llvm-rc] Serialize STRINGTABLE statements to .res files (serialization, pt 8).: D38410: [llvm-rc] Dump VERSIONINFO resources to .res files (serialization, pt 7). .
Sep 29 2017, 12:32 PM
mnbvmar created D38420: [llvm-rc] Serialize STRINGTABLE statements to .res files (serialization, pt 8)..
Sep 29 2017, 12:32 PM
mnbvmar committed rL314549: [llvm-rc] Serialize ACCELERATORS to .res files (serialization, pt 2)..
[llvm-rc] Serialize ACCELERATORS to .res files (serialization, pt 2).
Sep 29 2017, 12:09 PM
mnbvmar closed D37824: [llvm-rc] Serialize ACCELERATORS resources to .res files (serialization, pt 2). by committing rL314549: [llvm-rc] Serialize ACCELERATORS to .res files (serialization, pt 2)..
Sep 29 2017, 12:09 PM
mnbvmar closed D37283: [llvm-rc] Serialize HTML resources to .res files (serialization, pt 1)..

Seems this revision didn't close automatically. Fixing that.

Sep 29 2017, 10:51 AM
mnbvmar committed rL314541: [llvm-rc] Refactoring needed for ACCELERATORS and MENU resources..
[llvm-rc] Refactoring needed for ACCELERATORS and MENU resources.
Sep 29 2017, 10:48 AM
mnbvmar closed D37841: [llvm-rc] Refactoring needed for ACCELERATORS and MENU resources serialization (serialization, pt 1.5). by committing rL314541: [llvm-rc] Refactoring needed for ACCELERATORS and MENU resources..
Sep 29 2017, 10:48 AM
mnbvmar committed rL314538: [llvm-rc] Serialize HTML resources to .res files (serialization, pt 1)..
[llvm-rc] Serialize HTML resources to .res files (serialization, pt 1).
Sep 29 2017, 10:15 AM
mnbvmar added a dependency for D38410: [llvm-rc] Dump VERSIONINFO resources to .res files (serialization, pt 7). : D37878: [llvm-rc] Serialize CURSOR and ICON resources to .res files (serialization, pt 6)..
Sep 29 2017, 10:00 AM
mnbvmar added a dependent revision for D37878: [llvm-rc] Serialize CURSOR and ICON resources to .res files (serialization, pt 6).: D38410: [llvm-rc] Dump VERSIONINFO resources to .res files (serialization, pt 7). .
Sep 29 2017, 10:00 AM
mnbvmar created D38410: [llvm-rc] Dump VERSIONINFO resources to .res files (serialization, pt 7). .
Sep 29 2017, 10:00 AM
mnbvmar updated the diff for D37878: [llvm-rc] Serialize CURSOR and ICON resources to .res files (serialization, pt 6)..

Remove unnecessary .res file.

Sep 29 2017, 9:33 AM
mnbvmar updated the diff for D37878: [llvm-rc] Serialize CURSOR and ICON resources to .res files (serialization, pt 6)..

Refactored into FileWriter; updated tests.

Sep 29 2017, 9:32 AM

Sep 28 2017

mnbvmar committed rL314480: [llvm-rc] Import all make_unique invocations from llvm namespace..
[llvm-rc] Import all make_unique invocations from llvm namespace.
Sep 28 2017, 5:35 PM
mnbvmar committed rL314478: [llvm-rc] Add user-defined resources parsing ability. [8/8].
[llvm-rc] Add user-defined resources parsing ability. [8/8]
Sep 28 2017, 5:16 PM
mnbvmar closed D37033: [llvm-rc] Add user-defined resources parsing ability. [8/8] by committing rL314478: [llvm-rc] Add user-defined resources parsing ability. [8/8].
Sep 28 2017, 5:16 PM
mnbvmar committed rL314477: [llvm-rc] Add integer expressions parsing ability. [7/8].
[llvm-rc] Add integer expressions parsing ability. [7/8]
Sep 28 2017, 4:55 PM
mnbvmar closed D37022: [llvm-rc] Add integer expressions parsing ability. [7/8] by committing rL314477: [llvm-rc] Add integer expressions parsing ability. [7/8].
Sep 28 2017, 4:55 PM
mnbvmar committed rL314472: [llvm-rc] Fix-up for r314468 (argument-dependent lookup in make_unique)..
[llvm-rc] Fix-up for r314468 (argument-dependent lookup in make_unique).
Sep 28 2017, 4:14 PM
mnbvmar committed rL314468: [llvm-rc] Add VERSIONINFO parsing ability. [6/8].
[llvm-rc] Add VERSIONINFO parsing ability. [6/8]
Sep 28 2017, 3:43 PM
mnbvmar closed D37021: [llvm-rc] Add VERSIONINFO parsing ability. [6/8] by committing rL314468: [llvm-rc] Add VERSIONINFO parsing ability. [6/8].
Sep 28 2017, 3:43 PM
mnbvmar updated the diff for D37864: [llvm-rc] Add additional optional statements serialization support for DIALOG(EX) resources (serialization, pt 5)..

Moved binary .res output to its printable representation in dialog test.

Sep 28 2017, 2:50 PM
mnbvmar updated the diff for D37862: [llvm-rc] Serialize DIALOG(EX) resources to .res files (serialization, pt 4)..

Rewrite binary tests to ASCII hexdump and move them to .test files.

Sep 28 2017, 2:18 PM
mnbvmar updated the diff for D37828: [llvm-rc] Serialize MENU resources to .res files (serialization, pt 3)..

Some minor style changes.

Sep 28 2017, 2:16 PM
mnbvmar updated the diff for D37828: [llvm-rc] Serialize MENU resources to .res files (serialization, pt 3)..

Rewritten binary .res expected output to ASCII format.

Sep 28 2017, 1:49 PM
mnbvmar created D38370: Fix compilation problems and unsupported tests when running under QEMU 32-bit PowerPC emulator..
Sep 28 2017, 10:29 AM

Sep 27 2017

mnbvmar updated the diff for D37021: [llvm-rc] Add VERSIONINFO parsing ability. [6/8].

Rewritten fixed fields implementation a little bit. Now, we have an enumeration describing fixed field types, a list of field names, and a mapping from names to their types.

Sep 27 2017, 4:19 PM
mnbvmar added inline comments to D37021: [llvm-rc] Add VERSIONINFO parsing ability. [6/8].
Sep 27 2017, 2:32 PM

Sep 26 2017

mnbvmar updated the diff for D37824: [llvm-rc] Serialize ACCELERATORS resources to .res files (serialization, pt 2)..

Use llvm-readobj to examine the resulting .res files.

Sep 26 2017, 5:01 PM

Sep 21 2017

mnbvmar committed rL313912: [llvm-readobj] Fix big-endian byte swap in WindowsResourceDumper..
[llvm-readobj] Fix big-endian byte swap in WindowsResourceDumper.
Sep 21 2017, 1:38 PM
mnbvmar created D38150: Fix big-endian byte swap for WindowsResourceDumper..
Sep 21 2017, 1:05 PM
mnbvmar added a comment to D38058: [llvm-readobj] Teach readobj to output .res (WindowsResource)..
Sep 21 2017, 9:52 AM

Sep 20 2017

mnbvmar updated the diff for D37283: [llvm-rc] Serialize HTML resources to .res files (serialization, pt 1)..

Style fixes suggested in the comments. Integrated llvm-readobj into test invocation.

Sep 20 2017, 5:33 PM
mnbvmar committed rL313834: [llvm-readobj] Fix 'Teach readobj to dump .res files', pt 3..
[llvm-readobj] Fix 'Teach readobj to dump .res files', pt 3.
Sep 20 2017, 4:27 PM
mnbvmar committed rL313833: [llvm-readobj] Fix 'Teach readobj to dump .res files', pt 2..
[llvm-readobj] Fix 'Teach readobj to dump .res files', pt 2.
Sep 20 2017, 4:09 PM
mnbvmar committed rL313816: [llvm-readobj] Fix 'Teach readobj to dump .res files'..
[llvm-readobj] Fix 'Teach readobj to dump .res files'.
Sep 20 2017, 2:05 PM
mnbvmar committed rL313790: [llvm-readobj] Teach readobj to dump .res files (WindowsResource)..
[llvm-readobj] Teach readobj to dump .res files (WindowsResource).
Sep 20 2017, 11:35 AM
mnbvmar closed D38058: [llvm-readobj] Teach readobj to output .res (WindowsResource). by committing rL313790: [llvm-readobj] Teach readobj to dump .res files (WindowsResource)..
Sep 20 2017, 11:35 AM
mnbvmar added inline comments to D37283: [llvm-rc] Serialize HTML resources to .res files (serialization, pt 1)..
Sep 20 2017, 10:37 AM

Sep 19 2017

mnbvmar updated subscribers of D38058: [llvm-readobj] Teach readobj to output .res (WindowsResource)..
Sep 19 2017, 6:26 PM
mnbvmar updated the diff for D38058: [llvm-readobj] Teach readobj to output .res (WindowsResource)..

Fixed file header.

Sep 19 2017, 4:22 PM
mnbvmar added inline comments to D38058: [llvm-readobj] Teach readobj to output .res (WindowsResource)..
Sep 19 2017, 4:20 PM
mnbvmar created D38058: [llvm-readobj] Teach readobj to output .res (WindowsResource)..
Sep 19 2017, 4:15 PM
mnbvmar added inline comments to D37283: [llvm-rc] Serialize HTML resources to .res files (serialization, pt 1)..
Sep 19 2017, 10:27 AM

Sep 14 2017

mnbvmar added a dependent revision for D37864: [llvm-rc] Add additional optional statements serialization support for DIALOG(EX) resources (serialization, pt 5).: D37878: [llvm-rc] Serialize CURSOR and ICON resources to .res files (serialization, pt 6)..
Sep 14 2017, 5:17 PM
mnbvmar added a dependency for D37878: [llvm-rc] Serialize CURSOR and ICON resources to .res files (serialization, pt 6).: D37864: [llvm-rc] Add additional optional statements serialization support for DIALOG(EX) resources (serialization, pt 5)..
Sep 14 2017, 5:17 PM
mnbvmar created D37878: [llvm-rc] Serialize CURSOR and ICON resources to .res files (serialization, pt 6)..
Sep 14 2017, 5:17 PM
mnbvmar added a dependency for D37862: [llvm-rc] Serialize DIALOG(EX) resources to .res files (serialization, pt 4).: D37828: [llvm-rc] Serialize MENU resources to .res files (serialization, pt 3)..
Sep 14 2017, 1:11 PM
mnbvmar added a dependent revision for D37828: [llvm-rc] Serialize MENU resources to .res files (serialization, pt 3).: D37862: [llvm-rc] Serialize DIALOG(EX) resources to .res files (serialization, pt 4)..
Sep 14 2017, 1:11 PM
mnbvmar added a dependent revision for D37862: [llvm-rc] Serialize DIALOG(EX) resources to .res files (serialization, pt 4).: D37864: [llvm-rc] Add additional optional statements serialization support for DIALOG(EX) resources (serialization, pt 5)..
Sep 14 2017, 1:11 PM
mnbvmar added a dependency for D37864: [llvm-rc] Add additional optional statements serialization support for DIALOG(EX) resources (serialization, pt 5).: D37862: [llvm-rc] Serialize DIALOG(EX) resources to .res files (serialization, pt 4)..
Sep 14 2017, 1:11 PM
mnbvmar created D37864: [llvm-rc] Add additional optional statements serialization support for DIALOG(EX) resources (serialization, pt 5)..
Sep 14 2017, 1:10 PM
mnbvmar updated the diff for D37862: [llvm-rc] Serialize DIALOG(EX) resources to .res files (serialization, pt 4)..

Minor style improvement.

Sep 14 2017, 1:04 PM
mnbvmar created D37862: [llvm-rc] Serialize DIALOG(EX) resources to .res files (serialization, pt 4)..
Sep 14 2017, 12:58 PM

Sep 13 2017

mnbvmar updated the diff for D37828: [llvm-rc] Serialize MENU resources to .res files (serialization, pt 3)..

Rebase wrt patch D37841.

Sep 13 2017, 6:32 PM
mnbvmar updated the diff for D37824: [llvm-rc] Serialize ACCELERATORS resources to .res files (serialization, pt 2)..

Rebase wrt patch D37841.

Sep 13 2017, 6:30 PM
mnbvmar retitled D37841: [llvm-rc] Refactoring needed for ACCELERATORS and MENU resources serialization (serialization, pt 1.5). from D37824: [llvm-rc] Refactoring needed for ACCELERATORS and MENU resources serialization (serialization, pt 1.5). to [llvm-rc] Refactoring needed for ACCELERATORS and MENU resources serialization (serialization, pt 1.5)..
Sep 13 2017, 6:14 PM
mnbvmar added a dependent revision for D37283: [llvm-rc] Serialize HTML resources to .res files (serialization, pt 1).: D37841: [llvm-rc] Refactoring needed for ACCELERATORS and MENU resources serialization (serialization, pt 1.5)..
Sep 13 2017, 6:14 PM
mnbvmar created D37841: [llvm-rc] Refactoring needed for ACCELERATORS and MENU resources serialization (serialization, pt 1.5)..
Sep 13 2017, 6:14 PM
mnbvmar added a dependency for D37824: [llvm-rc] Serialize ACCELERATORS resources to .res files (serialization, pt 2).: D37841: [llvm-rc] Refactoring needed for ACCELERATORS and MENU resources serialization (serialization, pt 1.5)..
Sep 13 2017, 6:14 PM
mnbvmar added a dependency for D37841: [llvm-rc] Refactoring needed for ACCELERATORS and MENU resources serialization (serialization, pt 1.5).: D37283: [llvm-rc] Serialize HTML resources to .res files (serialization, pt 1)..
Sep 13 2017, 6:14 PM
mnbvmar added a dependent revision for D37841: [llvm-rc] Refactoring needed for ACCELERATORS and MENU resources serialization (serialization, pt 1.5).: D37824: [llvm-rc] Serialize ACCELERATORS resources to .res files (serialization, pt 2)..
Sep 13 2017, 6:14 PM
mnbvmar updated the diff for D37283: [llvm-rc] Serialize HTML resources to .res files (serialization, pt 1)..

This fixes @ecbeckmann's comment https://reviews.llvm.org/D37824#inline-329768 (set type IDs and memory flags as constants). It's probably better to fix this in the first patch this appears in.

Sep 13 2017, 5:48 PM
mnbvmar added a dependency for D37828: [llvm-rc] Serialize MENU resources to .res files (serialization, pt 3).: D37824: [llvm-rc] Serialize ACCELERATORS resources to .res files (serialization, pt 2)..
Sep 13 2017, 2:24 PM
mnbvmar added a dependent revision for D37824: [llvm-rc] Serialize ACCELERATORS resources to .res files (serialization, pt 2).: D37828: [llvm-rc] Serialize MENU resources to .res files (serialization, pt 3)..
Sep 13 2017, 2:24 PM
mnbvmar created D37828: [llvm-rc] Serialize MENU resources to .res files (serialization, pt 3)..
Sep 13 2017, 2:24 PM
mnbvmar updated the summary of D37824: [llvm-rc] Serialize ACCELERATORS resources to .res files (serialization, pt 2)..
Sep 13 2017, 1:18 PM
mnbvmar updated the summary of D37824: [llvm-rc] Serialize ACCELERATORS resources to .res files (serialization, pt 2)..
Sep 13 2017, 1:17 PM
mnbvmar updated the summary of D37824: [llvm-rc] Serialize ACCELERATORS resources to .res files (serialization, pt 2)..
Sep 13 2017, 1:16 PM
mnbvmar added a dependent revision for D37283: [llvm-rc] Serialize HTML resources to .res files (serialization, pt 1).: D37824: [llvm-rc] Serialize ACCELERATORS resources to .res files (serialization, pt 2)..
Sep 13 2017, 1:16 PM
mnbvmar added a dependency for D37824: [llvm-rc] Serialize ACCELERATORS resources to .res files (serialization, pt 2).: D37283: [llvm-rc] Serialize HTML resources to .res files (serialization, pt 1)..
Sep 13 2017, 1:16 PM
mnbvmar created D37824: [llvm-rc] Serialize ACCELERATORS resources to .res files (serialization, pt 2)..
Sep 13 2017, 1:16 PM
mnbvmar updated the diff for D37283: [llvm-rc] Serialize HTML resources to .res files (serialization, pt 1)..

Refactored the code to simplify the patches following this one.

Sep 13 2017, 11:42 AM

Aug 30 2017

mnbvmar updated the diff for D37283: [llvm-rc] Serialize HTML resources to .res files (serialization, pt 1)..

Changed the code according to Eric's suggestion; some bugfixes.

Aug 30 2017, 11:57 AM

Aug 29 2017

mnbvmar updated the diff for D37021: [llvm-rc] Add VERSIONINFO parsing ability. [6/8].

Small style fixes.

Aug 29 2017, 6:10 PM
mnbvmar updated the diff for D37283: [llvm-rc] Serialize HTML resources to .res files (serialization, pt 1)..

One file was missing from the patch.

Aug 29 2017, 6:08 PM
mnbvmar added a dependency for D37283: [llvm-rc] Serialize HTML resources to .res files (serialization, pt 1).: D37033: [llvm-rc] Add user-defined resources parsing ability. [8/8].
Aug 29 2017, 5:58 PM
mnbvmar added a dependent revision for D37033: [llvm-rc] Add user-defined resources parsing ability. [8/8]: D37283: [llvm-rc] Serialize HTML resources to .res files (serialization, pt 1)..
Aug 29 2017, 5:58 PM
mnbvmar created D37283: [llvm-rc] Serialize HTML resources to .res files (serialization, pt 1)..
Aug 29 2017, 5:58 PM
mnbvmar committed rL312028: [llvm-rc] Fix DIALOG(EX) parsing ability (parser, pt 5/8)..
[llvm-rc] Fix DIALOG(EX) parsing ability (parser, pt 5/8).
Aug 29 2017, 1:04 PM
mnbvmar closed D37271: [llvm-rc] Fix DIALOG(EX) parsing ability. [5/8] by committing rL312028: [llvm-rc] Fix DIALOG(EX) parsing ability (parser, pt 5/8)..
Aug 29 2017, 1:04 PM
mnbvmar created D37271: [llvm-rc] Fix DIALOG(EX) parsing ability. [5/8].
Aug 29 2017, 1:00 PM