This is an archive of the discontinued LLVM Phabricator instance.

Differential D46381

Fix BUILD_SHARED_LIB build after addition of dependency on llvm::WriteIndexToFile
AbandonedPublic

Authored by sbc100 on May 3 2018, 1:53 AM.

Details

Reviewers
• espindola
rdhindsa
Summary

The -DBUILD_SHARED_LIB=ON build seems to have been broken
in rL331405 with the addition of llvm::WriteIndexToFile.

This function lives in libLLVMBitWriter.so.

Diff Detail

Event Timeline

sbc100 created this revision.May 3 2018, 1:53 AM
Herald added a reviewer: • espindola. · View Herald TranscriptMay 3 2018, 1:53 AM
Herald added subscribers: llvm-commits, aheejin, arichardson and 2 others. · View Herald Transcript
sbc100 added a reviewer: rdhindsa.May 3 2018, 1:57 AM
sbc100 edited the summary of this revision. (Show Details)
rdhindsa accepted this revision.May 3 2018, 9:16 AM

LGTM

This revision is now accepted and ready to land.May 3 2018, 9:16 AM
sbc100 added a comment.May 3 2018, 10:12 AM

Looks like this was already fixed by rLLD331444

sbc100 abandoned this revision.May 3 2018, 10:12 AM

Revision Contents

PathSize
ELF/
1 line

Diff 144990

ELF/CMakeLists.txt

Show All 40 Linesadd_lld_library(lldELF
SyntheticSections.cpp SyntheticSections.cpp
Target.cpp Target.cpp
Thunks.cpp Thunks.cpp
Writer.cpp Writer.cpp
LINK_COMPONENTS LINK_COMPONENTS
${LLVM_TARGETS_TO_BUILD} ${LLVM_TARGETS_TO_BUILD}
BinaryFormat BinaryFormat
BitWriter
Core Core
DebugInfoDWARF DebugInfoDWARF
LTO LTO
MC MC
Object Object
Option Option
Support Support
LINK_LIBS LINK_LIBS
lldCommon lldCommon
${LLVM_PTHREAD_LIB} ${LLVM_PTHREAD_LIB}
DEPENDS DEPENDS
ELFOptionsTableGen ELFOptionsTableGen
${tablegen_deps} ${tablegen_deps}
) )