This is an archive of the discontinued LLVM Phabricator instance.

Undef the macros after their use
ClosedPublic

Authored by hiraditya on May 2 2018, 11:21 PM.

Diff Detail

Event Timeline

hiraditya created this revision.May 2 2018, 11:21 PM

I don't see anything wrong with this change, but will be good idea to wait for code owner approval.

include/llvm/MC/MCLinkerOptimizationHint.h
80 ↗(On Diff #144983)

You could return {}.

hiraditya updated this revision to Diff 145043.May 3 2018, 10:43 AM

return {}.

hiraditya marked an inline comment as done.May 3 2018, 10:43 AM

I'll merge this patch as if there are no further feedbacks.

Herald added a project: Restricted Project. · View Herald TranscriptSep 29 2019, 7:40 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 29 2019, 7:45 PM
This revision was automatically updated to reflect the committed changes.